Skip to content

Support custom filter strategy #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dnperfors opened this issue Nov 10, 2017 · 1 comment
Closed

Support custom filter strategy #186

dnperfors opened this issue Nov 10, 2017 · 1 comment
Labels
enhancement extensibility

Comments

@dnperfors
Copy link
Contributor

Filtering is not really specified in the jsonapi.org specification and we have actually chosen an other filter strategy than is implemented in JsonApiDotNetCore.
Would it be possible/desirable to make the parsing of query strings more adaptable, so that we can override the ParseFilterQuery method to support queries like filter[attribute][lt]=value instead?
@jaredcnance
Copy link
Contributor

I agree that this is an area where we need to be more flexible. What I would like to see happen is the parsing logic moved out of QuerySet into an injectable service. The way it is currently written, JsonApiContext implicitly depends on QuerySet which contains the parsing logic. There should be a service which parses the queries and returns the built QuerySet

jaredcnance added a commit that referenced this issue Nov 13, 2017
@jaredcnance
refactor(query-set): move logic into IQueryParser to improve extensib…
b271247 
…ility

closes #186
@jaredcnance jaredcnance mentioned this issue Nov 13, 2017
Merged
3 tasks
jaredcnance added a commit that referenced this issue Nov 13, 2017
@jaredcnance
refactor(query-set): move logic into IQueryParser to improve extensib…
d6afafd 
…ility

* chore(csproj): bump package version

* refactor(query-set): move logic into IQueryParser to improve extensibility

closes #186
jaredcnance added a commit that referenced this issue Aug 12, 2018
@jaredcnance
refactor(query-set): move logic into IQueryParser to improve extensib…
e6e4cce 
…ility

* chore(csproj): bump package version

* refactor(query-set): move logic into IQueryParser to improve extensibility

closes #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement extensibility
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnperfors @jaredcnance