Replace UnreachableCodeException with built-in UnreachableException

Author: bkoelman

src/JsonApiDotNetCore.OpenApi.Client.NSwag/JsonApiClient.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Linq.Expressions;
 using System.Reflection;
 using Newtonsoft.Json;
@@ -175,7 +176,7 @@ public override bool CanConvert(Type objectType)
 
         public override object ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
@@ -236,7 +237,7 @@ public override bool CanConvert(Type objectType)
 
         public override object ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)

src/JsonApiDotNetCore.OpenApi.Client.NSwag/UnreachableCodeException.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Reflection;
 using JsonApiDotNetCore.Errors;
 using JsonApiDotNetCore.Middleware;
@@ -125,7 +126,7 @@ private static void UpdateProducesResponseTypeAttribute(ActionDescriptor endpoin
             }
         }
 
-        throw new UnreachableCodeException();
+        throw new UnreachableException();
     }
 
     private static bool ProducesJsonApiResponseDocument(ActionDescriptor endpoint)

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiActionDescriptorCollectionProvider.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Reflection;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Controllers;
@@ -45,7 +46,7 @@ public JsonApiEndpointMetadataContainer Get(MethodInfo controllerAction)
 
         if (primaryResourceType == null)
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         IJsonApiRequestMetadata? requestMetadata = GetRequestMetadata(endpoint, primaryResourceType);

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiMetadata/JsonApiEndpointMetadataProvider.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using JsonApiDotNetCore.Middleware;
 using Microsoft.AspNetCore.Mvc.ApiExplorer;
 using Microsoft.AspNetCore.Mvc.Formatters;
@@ -18,7 +19,7 @@ public bool CanRead(InputFormatterContext context)
     /// <inheritdoc />
     public Task<InputFormatterResult> ReadAsync(InputFormatterContext context)
     {
-        throw new UnreachableCodeException();
+        throw new UnreachableException();
     }
 
     /// <inheritdoc />

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiRequestFormatMetadataProvider.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Net;
 using System.Reflection;
 using JsonApiDotNetCore.Configuration;
@@ -108,7 +109,7 @@ private static bool IsEndpointAvailable(JsonApiEndpoints endpoint, ResourceType
             JsonApiEndpoints.PatchRelationship => availableEndpoints.HasFlag(JsonApiEndpoints.PatchRelationship),
             JsonApiEndpoints.Delete => availableEndpoints.HasFlag(JsonApiEndpoints.Delete),
             JsonApiEndpoints.DeleteRelationship => availableEndpoints.HasFlag(JsonApiEndpoints.DeleteRelationship),
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
     }
 
@@ -178,7 +179,7 @@ private static HttpStatusCode[] GetSuccessStatusCodesForEndpoint(JsonApiEndpoint
             [
                 HttpStatusCode.NoContent
             ],
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
     }
 
@@ -236,7 +237,7 @@ private HttpStatusCode[] GetErrorStatusCodesForEndpoint(JsonApiEndpointWrapper e
                 HttpStatusCode.NotFound,
                 HttpStatusCode.Conflict
             ],
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
     }
 

src/JsonApiDotNetCore.OpenApi.Swashbuckle/OpenApiEndpointConvention.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Reflection;
 using System.Text.Json;
 using Humanizer;
@@ -66,7 +67,7 @@ private static string GetTemplate(ApiDescription endpoint)
 
         if (!SchemaOpenTypeToOpenApiOperationIdTemplateMap.TryGetValue(bodyType, out string? template))
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         return template;
@@ -78,7 +79,7 @@ private static Type GetBodyType(ApiDescription endpoint)
 
         if (producesResponseTypeAttribute == null)
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         ControllerParameterDescriptor? requestBodyDescriptor = endpoint.ActionDescriptor.GetBodyParameterDescriptor();
@@ -96,7 +97,7 @@ private string ApplyTemplate(string openApiOperationIdTemplate, ResourceType? re
     {
         if (endpoint.RelativePath == null || endpoint.HttpMethod == null)
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         string method = endpoint.HttpMethod.ToLowerInvariant();

src/JsonApiDotNetCore.OpenApi.Swashbuckle/OpenApiOperationIdSelector.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using Microsoft.OpenApi.Models;
 
 namespace JsonApiDotNetCore.OpenApi.Swashbuckle;
@@ -21,7 +22,7 @@ public static void ReorderProperties(this OpenApiSchema fullSchema, IEnumerable<
 
         if (fullSchema.Properties.Count != propertiesInOrder.Count)
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         fullSchema.Properties = propertiesInOrder;

src/JsonApiDotNetCore.OpenApi.Swashbuckle/OpenApiSchemaExtensions.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using JsonApiDotNetCore.AtomicOperations;
 using JsonApiDotNetCore.Configuration;
 using JsonApiDotNetCore.Middleware;
@@ -121,7 +122,7 @@ private void GenerateSchemaForResourceOperation(Type operationOpenType, Resource
             AtomicOperationCode.Add => WriteOperationKind.CreateResource,
             AtomicOperationCode.Update => WriteOperationKind.UpdateResource,
             AtomicOperationCode.Remove => WriteOperationKind.DeleteResource,
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
 
         if (!_atomicOperationFilter.IsEnabled(resourceType, writeOperation))
@@ -158,7 +159,7 @@ private void GenerateSchemaForRelationshipOperation(Type operationOpenType, Rela
             AtomicOperationCode.Add => WriteOperationKind.AddToRelationship,
             AtomicOperationCode.Update => WriteOperationKind.SetRelationship,
             AtomicOperationCode.Remove => WriteOperationKind.RemoveFromRelationship,
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
 
         if (!_atomicOperationFilter.IsEnabled(relationship.LeftType, writeOperation))
@@ -211,7 +212,7 @@ private static bool IsToOneRelationshipEnabled(HasOneAttribute relationship, Wri
         return writeOperation switch
         {
             WriteOperationKind.SetRelationship => relationship.Capabilities.HasFlag(HasOneCapabilities.AllowSet),
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
     }
 
@@ -222,7 +223,7 @@ private static bool IsToManyRelationshipEnabled(HasManyAttribute relationship, W
             WriteOperationKind.SetRelationship => relationship.Capabilities.HasFlag(HasManyCapabilities.AllowSet),
             WriteOperationKind.AddToRelationship => relationship.Capabilities.HasFlag(HasManyCapabilities.AllowAdd),
             WriteOperationKind.RemoveFromRelationship => relationship.Capabilities.HasFlag(HasManyCapabilities.AllowRemove),
-            _ => throw new UnreachableCodeException()
+            _ => throw new UnreachableException()
         };
     }
 

src/JsonApiDotNetCore.OpenApi.Swashbuckle/SchemaGenerators/Bodies/AtomicOperationsBodySchemaGenerator.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using JsonApiDotNetCore.OpenApi.Swashbuckle.JsonApiObjects.AtomicOperations;
 using Microsoft.OpenApi.Any;
 using Microsoft.OpenApi.Models;
@@ -74,7 +75,7 @@ public void MapDiscriminator(OpenApiSchema referenceSchemaForOperation, string d
 
         if (!schemaRepository.TryLookupByType(AtomicOperationAbstractType, out OpenApiSchema? referenceSchemaForAbstractOperation))
         {
-            throw new UnreachableCodeException();
+            throw new UnreachableException();
         }
 
         OpenApiSchema fullSchemaForAbstractOperation = schemaRepository.Schemas[referenceSchemaForAbstractOperation.Reference.Id];