Added marker to our TODOs

Author: Bart Koelman

src/JsonApiDotNetCore/Repositories/EntityFrameworkCoreRepository.cs

@@ -16,7 +16,7 @@
 using Microsoft.EntityFrameworkCore.Metadata;
 using Microsoft.Extensions.Logging;
 
-// TODO: Tests that cover relationship updates with required relationships. All relationships right now are currently optional.
+// TODO: @ThisPR Tests that cover relationship updates with required relationships. All relationships right now are currently optional.
 //    - Setting a required relationship to null
 //    - Creating resource with resource
 //    - One-to-one required / optional => what is the current behavior?
@@ -189,7 +189,7 @@ public virtual async Task AddToToManyRelationshipAsync(TId primaryId, ISet<IIden
                 await UpdateRelationshipAsync(relationship, primaryResource, secondaryResourceIds);
                 await SaveChangesAsync();
 
-                // TODO: Do we need to flush cache here?
+                // TODO: @ThisPR Do we need to flush cache here?
             }
         }
 
@@ -251,7 +251,7 @@ public virtual async Task SetRelationshipAsync(TResource primaryResource, object
             await UpdateRelationshipAsync(relationship, primaryResource, secondaryResourceIds);
             await SaveChangesAsync();
 
-            // TODO: Do we need to flush cache here?
+            // TODO: @ThisPR Do we need to flush cache here?
         }
 
         /// <inheritdoc />
@@ -298,7 +298,7 @@ public virtual async Task DeleteAsync(TId id)
             _dbContext.Remove(resource);
             await SaveChangesAsync();
 
-            // TODO: Do we need to flush cache here?
+            // TODO: @ThisPR Do we need to flush cache here?
         }
 
         private NavigationEntry GetNavigationEntry(TResource resource, RelationshipAttribute relationship)
@@ -352,7 +352,7 @@ public virtual async Task RemoveFromToManyRelationshipAsync(TResource primaryRes
             await UpdateRelationshipAsync(relationship, primaryResource, rightResources);
             await SaveChangesAsync();
 
-            // TODO: Do we need to flush cache here?
+            // TODO: @ThisPR Do we need to flush cache here?
         }
 
         /// <inheritdoc />
@@ -483,7 +483,7 @@ private static object GetNonNullValueForProperty(PropertyInfo propertyInfo)
 
             if (Nullable.GetUnderlyingType(propertyType) != null)
             {
-                // TODO: Write test with primary key property type int? or equivalent. 
+                // TODO: @ThisPR Write test with primary key property type int? or equivalent. 
                 propertyType = propertyInfo.PropertyType.GetGenericArguments()[0];
             }
 

src/JsonApiDotNetCore/Serialization/BaseDeserializer.cs

@@ -120,7 +120,7 @@ protected virtual IIdentifiable SetRelationships(IIdentifiable resource, IDictio
                     continue;
                 }
 
-                // TODO: Extra validation to make sure there are no list-like data for HasOne relationships and vice versa (Write test)
+                // TODO: @ThisPR Extra validation to make sure there are no list-like data for HasOne relationships and vice versa (Write test)
                 if (attr is HasOneAttribute hasOneAttribute)
                 {
                     SetHasOneRelationship(resource, hasOneAttribute, relationshipData);

src/JsonApiDotNetCore/Services/JsonApiResourceService.cs

@@ -17,7 +17,7 @@
 
 namespace JsonApiDotNetCore.Services
 {
-    // TODO: Add write operations to our documentation.
+    // TODO: @ThisPR Add write operations to our documentation.
 
     /// <inheritdoc />
     public class JsonApiResourceService<TResource, TId> :

test/JsonApiDotNetCoreExampleTests/Acceptance/ManyToManyTests.cs

@@ -10,7 +10,7 @@
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance
 {
-    // TODO: Move left-over tests in this file.
+    // TODO: @ThisPR Move left-over tests in this file.
 
     public sealed class ManyToManyTests : IClassFixture<IntegrationTestContext<Startup, AppDbContext>>
     {

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/FetchingRelationshipsTests.cs

@@ -60,7 +60,7 @@ public async Task When_getting_existing_ToOne_relationship_it_should_succeed()
 
             var json = JsonConvert.DeserializeObject<JObject>(body).ToString();
 
-            // TODO: links/related was removed from the expected response body here, which violates the json:api spec.
+            // TODO: @ThisPR links/related was removed from the expected response body here, which violates the json:api spec.
 
             string expected = @"{
   ""links"": {

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/UpdatingRelationshipsTests.cs

@@ -13,7 +13,7 @@
 
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec
 {
-    // TODO: Move left-over tests in this file.
+    // TODO: @ThisPR Move left-over tests in this file.
 
     public sealed class UpdatingRelationshipsTests : IClassFixture<IntegrationTestContext<Startup, AppDbContext>>
     {

test/JsonApiDotNetCoreExampleTests/IntegrationTests/Writing/RgbColor.cs

@@ -8,7 +8,7 @@ public sealed class RgbColor : Identifiable<string>
         [Attr]
         public string DisplayName { get; set; }
 
-        // TODO: Change into required relationship and add a test that fails when trying to assign null.
+        // TODO: @ThisPR Change into required relationship and add a test that fails when trying to assign null.
         [HasOne]
         public WorkItemGroup Group { get; set; }
     }