test

Author: 75lb

dist/index.cjs

@@ -143,10 +143,6 @@ class Explain extends JsdocCommand {
       });
       handle.on('error', reject);
     });
-    // console.log(handle.stdout.closed, handle.stdout.isPaused(), handle.stdout.readable, handle.stdout.destroyed, handle.stdout.errorer, handle.stdout.readableEnded)
-    // jsdocOutput.stdout = await streamReadText(handle.stdout)
-    // jsdocOutput.stderr = await streamReadText(handle.stderr)
-    // console.log(jsdocOutput)
     try {
       if (code > 0) {
         throw new Error('jsdoc exited with non-zero code: ' + code)
@@ -166,41 +162,6 @@ class Explain extends JsdocCommand {
     }
   }
 
-  async _runJsdoc1 () {
-    return new Promise((resolve, reject) => {
-      const jsdocArgs = [
-        this.jsdocPath,
-        ...toSpawnArgs(this.jsdocOptions),
-        '-X',
-        ...(this.options.source.length ? this.tempFileSet.files : this.inputFileSet.files)
-      ];
-      let jsdocOutput = { stdout: '', stderr: '' };
-      const handle = cp.spawn('node', jsdocArgs);
-      streamReadText(handle.stdout).then(stdout => jsdocOutput.stdout = stdout);
-      streamReadText(handle.stderr).then(stderr => jsdocOutput.stderr = stderr);
-      handle.on('close', (code) => {
-        try {
-          if (code > 0) {
-            throw new Error('jsdoc exited with non-zero code: ' + code)
-          } else {
-            const explainOutput = JSON.parse(jsdocOutput.stdout);
-            if (this.options.cache) {
-              this.cache.write(this.cacheKey, explainOutput).then(() => resolve(explainOutput));
-            } else {
-              resolve(explainOutput);
-            }
-          }
-        } catch (err) {
-          const firstLineOfStdout = jsdocOutput.stdout.split(/\r?\n/)[0];
-          const jsdocErr = new Error(jsdocOutput.stderr.trim() || firstLineOfStdout || 'Jsdoc failed.');
-          jsdocErr.name = 'JSDOC_ERROR';
-          jsdocErr.cause = err;
-          reject(jsdocErr);
-        }
-      });
-    })
-  }
-
   async readCache () {
     if (this.cache) {
       /* Create the cache key then check the cache for a match, returning pre-generated output if so.

lib/explain.js

@@ -46,10 +46,6 @@ class Explain extends JsdocCommand {
       })
       handle.on('error', reject)
     })
-    // console.log(handle.stdout.closed, handle.stdout.isPaused(), handle.stdout.readable, handle.stdout.destroyed, handle.stdout.errorer, handle.stdout.readableEnded)
-    // jsdocOutput.stdout = await streamReadText(handle.stdout)
-    // jsdocOutput.stderr = await streamReadText(handle.stderr)
-    // console.log(jsdocOutput)
     try {
       if (code > 0) {
         throw new Error('jsdoc exited with non-zero code: ' + code)
@@ -69,41 +65,6 @@ class Explain extends JsdocCommand {
     }
   }
 
-  async _runJsdoc1 () {
-    return new Promise((resolve, reject) => {
-      const jsdocArgs = [
-        this.jsdocPath,
-        ...toSpawnArgs(this.jsdocOptions),
-        '-X',
-        ...(this.options.source.length ? this.tempFileSet.files : this.inputFileSet.files)
-      ]
-      let jsdocOutput = { stdout: '', stderr: '' }
-      const handle = cp.spawn('node', jsdocArgs)
-      streamReadText(handle.stdout).then(stdout => jsdocOutput.stdout = stdout)
-      streamReadText(handle.stderr).then(stderr => jsdocOutput.stderr = stderr)
-      handle.on('close', (code) => {
-        try {
-          if (code > 0) {
-            throw new Error('jsdoc exited with non-zero code: ' + code)
-          } else {
-            const explainOutput = JSON.parse(jsdocOutput.stdout)
-            if (this.options.cache) {
-              this.cache.write(this.cacheKey, explainOutput).then(() => resolve(explainOutput))
-            } else {
-              resolve(explainOutput)
-            }
-          }
-        } catch (err) {
-          const firstLineOfStdout = jsdocOutput.stdout.split(/\r?\n/)[0]
-          const jsdocErr = new Error(jsdocOutput.stderr.trim() || firstLineOfStdout || 'Jsdoc failed.')
-          jsdocErr.name = 'JSDOC_ERROR'
-          jsdocErr.cause = err
-          reject(jsdocErr)
-        }
-      })
-    })
-  }
-
   async readCache () {
     if (this.cache) {
       /* Create the cache key then check the cache for a match, returning pre-generated output if so.

test/explain.js

@@ -50,10 +50,11 @@ test.set('.explain({ files }): files is empty', async function () {
 })
 
 test.set('Spaces in jsdoc command path', async function () {
-  process.env.JSDOC_PATH = 'test/fixture/folder with spaces/jsdoc'
+  process.env.JSDOC_PATH = 'test/fixture/folder with spaces/fake-jsdoc.js'
   const f = new Fixture('class-all')
   let output = await jsdoc.explain({ files: f.sourcePath })
-  a.ok(/a class with all of the things/.test(JSON.stringify(output)))
+  a.equal(output.length, 4)
+  process.env.JSDOC_PATH = ''
 })
 
 export { test, only, skip }

test/fixture/folder with spaces/fake-jsdoc.js

@@ -0,0 +1 @@
+console.log(JSON.stringify(process.argv))