Skip to content

Commit f0ace7c

Browse files
committed
Changes from @12wrigja code review comments
1 parent 6747493 commit f0ace7c

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

lib/ecmascript.ts

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -744,10 +744,10 @@ export function ToTemporalDateTimeRoundingIncrement(
744744
smallestUnit: keyof TemporalDateTimeRoundingMaximumIncrements
745745
) {
746746
const maximumIncrements: TemporalDateTimeRoundingMaximumIncrements = {
747-
year: undefined as number | undefined,
748-
month: undefined as number | undefined,
749-
week: undefined as number | undefined,
750-
day: undefined as number | undefined,
747+
year: undefined,
748+
month: undefined,
749+
week: undefined,
750+
day: undefined,
751751
hour: 24,
752752
minute: 60,
753753
second: 60,
@@ -808,6 +808,21 @@ export function ToSecondsStringPrecision(options: Temporal.ToStringPrecisionOpti
808808
}
809809
}
810810

811+
export function ToLargestTemporalUnit<Allowed extends Temporal.DateTimeUnit, Disallowed extends Temporal.DateTimeUnit>(
812+
options: { largestUnit?: Temporal.LargestUnitOption<Allowed> },
813+
fallback: Allowed | 'auto',
814+
disallowedStrings?: ReadonlyArray<Disallowed>
815+
): Allowed | 'auto';
816+
export function ToLargestTemporalUnit<
817+
Allowed extends Temporal.DateTimeUnit,
818+
Disallowed extends Temporal.DateTimeUnit,
819+
IfAuto extends Allowed | undefined = Allowed
820+
>(
821+
options: { largestUnit?: Temporal.LargestUnitOption<Allowed> },
822+
fallback: Allowed | 'auto',
823+
disallowedStrings: ReadonlyArray<Disallowed>,
824+
autoValue?: IfAuto
825+
): Allowed;
811826
export function ToLargestTemporalUnit<
812827
Allowed extends Temporal.DateTimeUnit,
813828
Disallowed extends Temporal.DateTimeUnit,
@@ -880,7 +895,8 @@ export function ToRelativeTemporalObject(options: {
880895
| undefined;
881896
}): Temporal.ZonedDateTime | Temporal.PlainDateTime | undefined {
882897
const relativeTo = options.relativeTo;
883-
// TODO: file a bug against TypeScript because `as undefined` below should not be needed.
898+
// TODO: `as undefined` below should not be needed. Verify that it can be
899+
// removed after strictNullChecks is enabled.
884900
if (relativeTo === undefined) return relativeTo as undefined;
885901

886902
let offsetBehaviour: OffsetBehaviour = 'option';

0 commit comments

Comments
 (0)