Skip to content

Commit ef50739

Browse files
authored
Merge pull request #10203 from js-org/MattIPv4/readme-template-tweaks
Update PR template guidance to highlight content requirements
2 parents a644898 + 99c4c69 commit ef50739

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

PULL_REQUEST_TEMPLATE.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,19 @@
22
33
Thanks for creating a pull request to request a new subdomain from JS.ORG
44
5-
Before creating your pull request, please complete the following steps:
5+
Before creating your pull request, please read and complete the following steps:
66
77
- Ensure that your pull request changes only the cnames_active.js file, adding a single new line for your subdomain request
8-
- Tick the two checkboxes, agreeing to the sentences, below by placing an x inside the square brackets ([ ] becomes [x])
9-
- Add a link (GitHub repository, Vercel deployment, etc.) and explanation below for your content so we can validate your request
8+
- Follow the existing format established by the other entries, a new line with the subdomain as the key and the target hostname as the value
9+
- Add your new line to the file in alphabetical order, and follow the guidance given by the comments in the file itself
10+
11+
- Fill out this pull request template in your pull request description, maintaining the format provided to you
12+
- Tick the two checkboxes, agreeing to the sentences, below by placing an x inside the square brackets ([ ] becomes [x])
13+
- Add a link (GitHub repository, Vercel deployment, etc.), so we can review your site
14+
- Explain what your site content is and how it relates to the JavaScript community/ecosystem, so we can validate your request
15+
16+
- Ensure that your site content follows the content requirements set out in our README: https://github.com/js-org/js.org#content-requirements
17+
- Notably, make sure that your site is not a personal site, and that it is clearly content that is relevant to the JavaScript community/ecosystem
1018
1119
-->
1220

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ As above with adding a subdomain to a GitHub Pages site, the final step is to ma
5454

5555
---
5656

57+
## Content Requirements
58+
5759
> [!IMPORTANT]
5860
> Please be aware that there are some rules that apply to website content hosted on JS.ORG subdomains:
5961
>

0 commit comments

Comments
 (0)