Draggable: $.ui.ddmanager.current release on draggable _destroy #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed, and now passes all tests / style guides |
| @@ -91,6 +91,11 @@ $.widget("ui.draggable", $.ui.mouse, { | |||
| this.element.removeClass( "ui-draggable ui-draggable-dragging ui-draggable-disabled" ); | |||
| this._removeHandleClassName(); | |||
| this._mouseDestroy(); | |||
|
|
|||
| if ($.ui.ddmanager && $.ui.ddmanager.current && $.ui.ddmanager.current.element && | |||
There was a problem hiding this comment.
Is it ever the case that current exists but current.element does not?
This still doesn't conform to the style guide, but we can fix that when we merge. For reference:
- Use
element[ 0 ]instead ofelement.get( 0 ); there's never a reason to use.get(). - We use liberal spacing, which you're missing.
- The indentation for the second line of the conditional is wrong.
Closed
…ggable instance Fixes: #10667
| @@ -84,6 +84,8 @@ $.widget("ui.draggable", $.ui.mouse, { | |||
| }, | |||
|
|
|||
| _destroy: function() { | |||
| var ddmanager = $.ui.ddmanager; | |||
|
Closing due to inactivity and lack of a CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10667