Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Conversation

kovrov
Copy link

@kovrov kovrov commented Apr 21, 2012

In certain scenarios "loading" message/spinner have to be shown after page loaded. E.g. when fetching additional data via ajax requests in page init.

This patch prevent unwanted hidePageLoadingMsg when option.showLoadMsg set to false.

@johnbender
Copy link
Contributor

@kovrov

This is a good idea for a feature and something we can easily support. I'm going to defer it in the interest of possibly exposing a method during an upcoming navigation refactor. You can view your feature request here:

https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

@johnbender johnbender closed this May 7, 2012
@kovrov
Copy link
Author

kovrov commented May 8, 2012

The way I see this, it's not a request for a new feature, but rather fixing existing one. As jQuery Mobile user I expect that if I do $.mobile.changePage(to, {showLoadMsg:false}), framework will not call neither showPageLoadingMsg nor hidePageLoadingMsg. This patch just prevent unnecessary call to hidePageLoadingMsg. This should not affect existing user code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants