Core: Make migrateWarnProp not return the prop for disabled patches #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: 1. Don't warn just on access of `jQuery.fn.push`, etc., but when it's called. 2. Rename some internal methods.
mgol
commented
Apr 8, 2025
Comment on lines
-119
to
-120
| // The function may not have existed originally so we need a fallback. | ||
| ( origFunc || jQuery.noop ); |
There was a problem hiding this comment.
I'm not sure why I added this noop fallback originally, but if the patch is disabled, the function should not be available if it wasn't there originally. I added tests for that (the push & isArray ones).
mgol
added
the
Discuss in Meeting
|
Adding "Discuss in Meeting" as this blocks another patch for 4.0.0. |
timmywil
approved these changes
Apr 14, 2025
mgol
added
4.x-only
and removed
Needs review
Discuss in Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
jQuery.fn.push, etc., but when it's called.