This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Fix for #2416 #2492
Merged
Fix for #2416 #2492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Could you add a unit test to that pull request? |
|
Sure. It's a explicit test for this issue, as all other aspects are already covered. |
| $searchPage.find('input').val('*'); | ||
| $searchPage.find('input').trigger('change'); | ||
|
|
||
| setTimeout(function() { |
There was a problem hiding this comment.
no need for a setTimeout here
There was a problem hiding this comment.
Same for the other filter-tests. Fixed in 68e2839
gseguin
added a commit
that referenced
this pull request
Oct 21, 2011
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2416 in a appropriate way.