Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

$.mobile.changePage ignores pageContainer option in JQM 1.4.0RC1 #6691

Closed
@nonplus

Description

@nonplus

The refactored (deprecated) $.mobile.changePage method in JQM 1.4, no longer pays attention to the pageContainer specified via options. Thus, the following call will ignore the specified pageContainer:

$.mobile.changePage(to, { pageContainer: $myContainer });

The bug is in jquery.mobile.navigation.js:

Current (wrong) implementation:

    $.mobile.changePage = function( to, options ) {
        $.mobile.pageContainer.pagecontainer( "change", to, options );
    };

This could be fixed like so:

    $.mobile.changePage = function( to, options ) {
        var settings = options || {};
        (settings.pageContainer || $.mobile.pageContainer).pagecontainer( "change", to, options );
    };

Sorry, I don't have a test page for this (not easy to simplify our code...)

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions