This repository was archived by the owner on May 26, 2020. It is now read-only.
Optimize jwt_decode_handler #344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
optimize-jwt_decode_handler
branch
from
f4c041e to
e69b7e2
Compare
blueyed
force-pushed
the
optimize-jwt_decode_handler
branch
from
e69b7e2 to
db5dc36
Compare
1. There is no need to decode the payload without verification first, in case `api_settings.JWT_PUBLIC_KEY` is used. 2. It also skips decoding in case `api_settings.JWT_GET_USER_SECRET_KEY` is not used. This might be a problem in case somebody is monkey-patching `jwt_get_secret_key`, but that should not be considered stable/public API, should it?
blueyed
force-pushed
the
optimize-jwt_decode_handler
branch
from
db5dc36 to
64f0859
Compare
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 14 14
Lines 847 847
Branches 29 29
=======================================
Hits 768 768
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case
api_settings.JWT_PUBLIC_KEYis used.api_settings.JWT_GET_USER_SECRET_KEYis not used.This might be a problem in case somebody is monkey-patching
jwt_get_secret_key, but that should not be considered stable/publicAPI, should it?
I had this still from when working on #341.
Might be better to keep this for after the currently planned release in any way.