Commit 6717275
Fix build with newer cecil (from overriden source path) (dotnet#428)
When trying to use newer mono in XA, we run into issues where cecil
(from mono repo) doesn't build anymore. Context:
dotnet/android#3159
Turned out we need to restore nuget packages for cecil before the
build to avoid errors like:
Mono.Cecil/TypeSystem.cs(83,29): error CS0518: Predefined type 'System.Object' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj]
Mono.Cecil/TypeSystem.cs(83,4): error CS0518: Predefined type 'System.Void' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj]
Mono.Cecil/TypeSystem.cs(81,4): error CS0518: Predefined type 'System.Object' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj]
8 Warning(s)
7700 Error(s)
Also grant access from `Mono.Cecil.[Mdb|Pdb]` assemblies to
`Mono.Cecil`. Looks like the access restrictions got tighter and so
CSC was complaining about the wrong key. It happens because the
original cecil key differ from our `product.snk` key, which we add in
our overrides and so access for `Mono.Cecil.[Mdb|Pdb]` granted by
original cecil `AssemblyInfo.cs` file is not valid anymore.
The error we were getting from CSC:
CSC : error CS0281: Friend access was granted by 'Mono.Cecil, Version=0.11.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065', but the public key of the output assembly does not match that specified by the attribute in the granting assembly. [/Users/rodo/git/xa2/external/mono/external/cecil/symbols/mdb/Mono.Cecil.Mdb.csproj]1 parent 7ef0be5 commit 6717275
File tree
2 files changed
+3
-1
lines changed- external
- src/Xamarin.Android.Cecil
2 files changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments