Create WeakMaps for Private Named Instance Fields #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and check that private names not used in parameters Signed-off-by: Max Heiber <[email protected]> Signed-off-by: Max Heiber <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
- generate statements (not expressions) for decorated class declarations which are transformed to class expressions by the ts transformer - don't generate empty constructor in esnext class transform Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
…, comments, and some other edge cases Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
* Add baselines * Update baselines Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
joeywatts
force-pushed
the
esnext-private-fields-weakmaps
branch
from
e3ff684 to
b362de1
Compare
joeywatts
changed the base branch from
private-name-integration
to
class-properties-esnext
added 3 commits
October 25, 2018 13:44
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
joeywatts
force-pushed
the
esnext-private-fields-weakmaps
branch
from
688d51c to
6baf417
Compare
joeywatts
force-pushed
the
class-properties-esnext
branch
2 times, most recently
from
86a90df to
861936e
Compare
|
closed (refer to bloomberg#15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just encompasses the necessary changes for generating the WeakMaps for the private named instance fields.