[WIP] yarn lint task WITH A TEMPORARY TRICK

NOTE that this has a trick to use eslint-config-standard-jsx
to quickly get a very basic working set of eslint
rules working with React that is up-to-date.

TODO: we need a new eslint config package that is designed to
gives us the basic set of working eslint rules
without using this kind of a trick.

Author: Christopher J. Brody

.eslintrc.yml

@@ -0,0 +1,12 @@
+extends:
+- eslint:recommended
+- plugin:react/recommended
+- standard-jsx
+
+rules:
+  react/jsx-indent: off
+  react/jsx-indent-props: off
+
+settings:
+  react:
+    version: detect

App.test.js

@@ -1,3 +1,5 @@
+/* eslint-env jasmine */
+
 import React from 'react';
 import App from './App';
 
@@ -6,4 +8,4 @@ import renderer from 'react-test-renderer';
 it('renders without crashing', () => {
     const rendered = renderer.create(<App />).toJSON();
     expect(rendered).toBeTruthy();
-});
+});

README.md

@@ -33,6 +33,7 @@ A full list of the scripts defined in `package.json` is shown below.
 | ------------------- | ------------------------------------------------------- |
 | `yarn web`          | Start CRA Development Build                             |
 | `yarn build-web`    | Create production build for web                         |
+| `yarn lint`         | Check results of eslint with very basic rules           |
 | `yarn start-expo`   | Start the Expo packager                                 |
 | `yarn start-native` | Start the native packager (not supported)               |
 | `yarn eject-native` | Eject from Expo                                         |

package.json

@@ -13,6 +13,7 @@
     "scripts": {
         "web": "react-scripts start",
         "build-web": "react-scripts build",
+        "lint": "eslint *.js src/**/*.js",
         "start-expo": "expo start",
         "start-native": "react-native-scripts start",
         "eject-native": "react-native-scripts eject",
@@ -28,6 +29,10 @@
         "babel-plugin-transform-object-rest-spread": "^6.26.0",
         "babel-plugin-transform-react-jsx-source": "^6.22.0",
         "babel-preset-expo": "^4.0.0",
+        "eslint": "^5.16.0",
+        "eslint-config-standard-jsx": "^6.0.2",
+        "eslint-plugin-import": "^2.16.0",
+        "eslint-plugin-react": "^7.12.4",
         "flow-bin": "^0.66.0",
         "react-art": "16.5.1",
         "react-native-scripts": "^1.13.1",

src/App.js

@@ -1,3 +1,5 @@
+/* eslint-env amd */
+
 import React from "react";
 import { View, Text, Animated, StyleSheet } from "react-native";
 

src/App.test.js

@@ -1,3 +1,6 @@
+/* eslint-env browser */
+/* eslint-env jasmine */
+
 import React from 'react';
 import ReactDOM from 'react-dom';
 import App from './App';

src/index.js

@@ -1,3 +1,5 @@
+/* eslint-env browser */
+
 import React from 'react';
 import ReactDOM from 'react-dom';
 

src/registerServiceWorker.js

@@ -1,3 +1,7 @@
+/* eslint-env browser */
+/* eslint-env node */
+/* eslint no-console: off */
+
 // In production, we register a service worker to serve assets from local cache.
 
 // This lets the app load faster on subsequent visits in production, and gives