Skip to content

Commit 8e16a1d

Browse files
authored
Merge pull request #10 from jitsecurity/fix-sorting-while-running-more-than-10-transformations
Fix data transformations order when running more than 10 transformations
2 parents 94f7211 + 5fb827e commit 8e16a1d

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "dynamo-data-transform",
3-
"version": "0.1.8",
3+
"version": "0.1.9",
44
"description": "DynamoDB Data Transformation Tool",
55
"main": "./index.js",
66
"repository": "https://github.com/jitsecurity/dynamo-data-transform",
@@ -57,4 +57,4 @@
5757
"dynamodt": "./cli/index.js",
5858
"ddt": "./cli/index.js"
5959
}
60-
}
60+
}

src/command-handlers/up.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const executeDataTransformation = async (ddb, transformation, table, isDryRun) =
3131
}
3232
};
3333

34-
const isGreaterThanLatesttransformationNumber = (fileName, latestDataTransformationNumber) => {
34+
const isGreaterThanLatestTransformationNumber = (fileName, latestDataTransformationNumber) => {
3535
const transformationFileNumber = parseTransformationFileNumber(fileName);
3636
return transformationFileNumber > latestDataTransformationNumber;
3737
};
@@ -42,10 +42,14 @@ const getScriptsToExecuteForTable = async (table, latestDataTransformationNumber
4242

4343
const currentTransformationFiles = transformationFiles.filter((fileName) => {
4444
const isJsFile = path.extname(fileName) === TRANSFORMATION_SCRIPT_EXTENSION;
45-
return isJsFile && isGreaterThanLatesttransformationNumber(fileName, latestDataTransformationNumber);
45+
return isJsFile && isGreaterThanLatestTransformationNumber(fileName, latestDataTransformationNumber);
4646
});
4747

48-
const sortedTransformationFiles = currentTransformationFiles.sort();
48+
const sortedTransformationFiles = currentTransformationFiles.sort((a, b) => {
49+
const aNumber = parseTransformationFileNumber(a);
50+
const bNumber = parseTransformationFileNumber(b);
51+
return aNumber - bNumber;
52+
});
4953

5054
const scriptsToExecute = sortedTransformationFiles
5155
.map((fileName) => require(

0 commit comments

Comments
 (0)