fix: invalid type for pool reset (#37)

ldez · web-flow · commit 93c54d3ffab3 · 2025-04-09T15:21:10.000+02:00
* chore: add .gitignore

* tests: add a falling test

* fix: invalid type for pool reset

* chore: ignore
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+/goconst
diff --git a/api.go b/api.go
@@ -41,8 +41,7 @@ func PutIssueBuffer(issues []Issue) {
 		issues[i].Str = ""
 	}
 	// Return the slice to the pool
-	issuesCopy := make([]Issue, 0, cap(issues))
-	IssuePool.Put(&issuesCopy)
+	IssuePool.Put(make([]Issue, 0, cap(issues))) //nolint:staticcheck
 }
 
 // Config contains all configuration options for the goconst analyzer.
diff --git a/api_test.go b/api_test.go
@@ -562,3 +562,8 @@ func checker(fset *token.FileSet) (*types.Checker, *types.Info) {
 	}
 	return types.NewChecker(cfg, fset, types.NewPackage("", "example"), info), info
 }
+
+func Test_IssuePool(t *testing.T) {
+	PutIssueBuffer([]Issue{})
+	GetIssueBuffer()
+}

Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,7 @@ func PutIssueBuffer(issues []Issue) {`
`41`	`41`	`issues[i].Str = ""`
`42`	`42`	`}`
`43`	`43`	`// Return the slice to the pool`
`44`		`- issuesCopy := make([]Issue, 0, cap(issues))`
`45`		`- IssuePool.Put(&issuesCopy)`
	`44`	`+ IssuePool.Put(make([]Issue, 0, cap(issues))) //nolint:staticcheck`
`46`	`45`	`}`
`47`	`46`
`48`	`47`	`// Config contains all configuration options for the goconst analyzer.`
Original file line number	Diff line number	Diff line change
`@@ -562,3 +562,8 @@ func checker(fset token.FileSet) (types.Checker, *types.Info) {`
`562`	`562`	`}`
`563`	`563`	`return types.NewChecker(cfg, fset, types.NewPackage("", "example"), info), info`
`564`	`564`	`}`
	`565`	`+`
	`566`	`+func Test_IssuePool(t *testing.T) {`
	`567`	`+ PutIssueBuffer([]Issue{})`
	`568`	`+ GetIssueBuffer()`
	`569`	`+}`