Fix data race in PlaybackStream
#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Signed-off-by: Florian Thienel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
statefield ofPlaybackStreamis used concurrently in different go routines. This leads to random race conditions that result in panics in the worst case. See https://github.com/ftl/faultdemo to reproduce the problem. It plays morse code in an endless loop and usually panics within one minute (please be patient - and turn down your volume).This change defines the new
stateMachinetype, which synchronizes the read and write access to thestateof thePlaybackStream.