Adding custom backoff function for API's that _can_ be excessive #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcollom
force-pushed
the
custom-backoff
branch
from
484f11f to
9e1f0b3
Compare
aidy
reviewed
Apr 29, 2025
| func HTTPBackOff(min, max time.Duration, attemptNum int, resp *http.Response) time.Duration { | ||
| sleep := retryablehttp.DefaultBackoff(min, max, attemptNum, resp) | ||
| if sleep.Abs() <= max { | ||
| return sleep.Abs() |
There was a problem hiding this comment.
Minor code legibility - this is backwards to how I'd normally read code. I'd normally expect the conditional to handle the exception case, here we're returning what I'd expect would be the normal mode of operation.
aidy
reviewed
Apr 29, 2025
| retryclient.RetryWaitMin = 1 * time.Second | ||
| // This custom backoff will fail requests that have a max wait of the RetryWaitMax | ||
| retryclient.Backoff = util.HTTPBackOff |
There was a problem hiding this comment.
Probably worth adding a note here that this could be removed if hashicorp/go-retryablehttp#247 is addressed.
aidy
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing it became apparent that version-checker would wait and honour the "Retry-After" Header and wait almost in definatly for the next request if a response was given such as below:
Lets not wait for
484289h20m8s!!!