Skip to content

Depends on ASM API plugin #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

jonesbusy
Copy link
Contributor

Need to depends on 2.426 line because older LTS baseline bundle ASM 9.5.
Other solution would be to include the asm bom on dependency management

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy added developer Changes which impact plugin developers dependencies Pull requests that update a dependency file labels Jan 7, 2024
@jonesbusy jonesbusy self-assigned this Jan 7, 2024
@jonesbusy jonesbusy force-pushed the feature/asm-plugin branch 2 times, most recently from a16a72a to 483f8da Compare January 13, 2024 14:05
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this to remain in draft? I just released the corresponding changes in jnr-posix-api.

@jonesbusy jonesbusy marked this pull request as ready for review March 14, 2024 18:35
@jonesbusy jonesbusy requested a review from a team as a code owner March 14, 2024 18:35
@jonesbusy
Copy link
Contributor Author

No reason, just didn't had time to take care of it. Thanks for the review.

@jonesbusy jonesbusy merged commit 57de85c into jenkinsci:main Mar 14, 2024
@jonesbusy jonesbusy deleted the feature/asm-plugin branch March 14, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file developer Changes which impact plugin developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants