Merge pull request microsoft#3085 from tinganho/nonInitExport

No emit on non initialized exports

Author: DanielRosenwasser

src/compiler/emitter.ts

@@ -139,7 +139,7 @@ var __param = (this && this.__param) || function (paramIndex, decorator) {
             let exportEquals: ExportAssignment;
             let hasExportStars: boolean;
 
-            /** write emitted output to disk*/
+            /** Write emitted output to disk */
             let writeEmittedFiles = writeJavaScriptFile;
 
             let detachedCommentsInfo: { nodePos: number; detachedCommentEndPos: number }[];
@@ -3059,13 +3059,15 @@ var __param = (this && this.__param) || function (paramIndex, decorator) {
             }
 
             function emitVariableStatement(node: VariableStatement) {
-                let startIsEmitted = true;
-                if (!(node.flags & NodeFlags.Export)) {
-                    startIsEmitted = tryEmitStartOfVariableDeclarationList(node.declarationList);
+                let startIsEmitted = false;
+                if (node.flags & NodeFlags.Export) {
+                    if (isES6ExportedDeclaration(node)) {
+                        // Exported ES6 module member
+                        write("export ");
+                        startIsEmitted = tryEmitStartOfVariableDeclarationList(node.declarationList);
+                    }
                 }
-                else if (isES6ExportedDeclaration(node)) {
-                    // Exported ES6 module member
-                    write("export ");
+                else {
                     startIsEmitted = tryEmitStartOfVariableDeclarationList(node.declarationList);
                 }
                 if (startIsEmitted) {

tests/baselines/reference/ExportVariableOfGenericTypeWithInaccessibleTypeAsTypeArgument.js

@@ -16,6 +16,5 @@ var A;
         }
         return B;
     })();
-    A.beez;
     A.beez2 = new Array();
 })(A || (A = {}));

tests/baselines/reference/NonInitializedExportInInternalModule.errors.txt

@@ -0,0 +1,47 @@
+tests/cases/conformance/internalModules/exportDeclarations/NonInitializedExportInInternalModule.ts(3,8): error TS1123: Variable declaration list cannot be empty.
+tests/cases/conformance/internalModules/exportDeclarations/NonInitializedExportInInternalModule.ts(4,5): error TS2304: Cannot find name 'let'.
+tests/cases/conformance/internalModules/exportDeclarations/NonInitializedExportInInternalModule.ts(5,10): error TS1123: Variable declaration list cannot be empty.
+
+
+==== tests/cases/conformance/internalModules/exportDeclarations/NonInitializedExportInInternalModule.ts (3 errors) ====
+    
+    module Inner {
+        var;
+           
+!!! error TS1123: Variable declaration list cannot be empty.
+        let;
+        ~~~
+!!! error TS2304: Cannot find name 'let'.
+        const;
+             
+!!! error TS1123: Variable declaration list cannot be empty.
+        
+        export var a;
+        export let b;
+        export var c: string;
+        export let d: number;
+        class A {}
+        export var e: A;
+        export let f: A;
+        
+        namespace B {
+            export let a = 1, b, c = 2;
+            export let x, y, z;
+        }
+        
+        module C {
+            export var a = 1, b, c = 2;
+            export var x, y, z;
+        }
+        
+        // Shouldn't be filtered
+        export var a1 = 1;
+        export let b1 = 1;
+        export var c1: string = 'a';
+        export let d1: number = 1;
+        class D {}
+        export var e1 = new D;
+        export let f1 = new D;
+        export var g1: D = new D;
+        export let h1: D = new D;
+    }

tests/baselines/reference/NonInitializedExportInInternalModule.js

@@ -0,0 +1,71 @@
+//// [NonInitializedExportInInternalModule.ts]
+
+module Inner {
+    var;
+    let;
+    const;
+    
+    export var a;
+    export let b;
+    export var c: string;
+    export let d: number;
+    class A {}
+    export var e: A;
+    export let f: A;
+    
+    namespace B {
+        export let a = 1, b, c = 2;
+        export let x, y, z;
+    }
+    
+    module C {
+        export var a = 1, b, c = 2;
+        export var x, y, z;
+    }
+    
+    // Shouldn't be filtered
+    export var a1 = 1;
+    export let b1 = 1;
+    export var c1: string = 'a';
+    export let d1: number = 1;
+    class D {}
+    export var e1 = new D;
+    export let f1 = new D;
+    export var g1: D = new D;
+    export let h1: D = new D;
+}
+
+//// [NonInitializedExportInInternalModule.js]
+var Inner;
+(function (Inner) {
+    var ;
+    let;
+    var ;
+    var A = (function () {
+        function A() {
+        }
+        return A;
+    })();
+    var B;
+    (function (B) {
+        B.a = 1, B.c = 2;
+    })(B || (B = {}));
+    var C;
+    (function (C) {
+        C.a = 1, C.c = 2;
+    })(C || (C = {}));
+    // Shouldn't be filtered
+    Inner.a1 = 1;
+    Inner.b1 = 1;
+    Inner.c1 = 'a';
+    Inner.d1 = 1;
+    var D = (function () {
+        function D() {
+        }
+        return D;
+    })();
+    Inner.e1 = new D;
+    Inner.f1 = new D;
+    Inner.g1 = new D;
+    Inner.h1 = new D;
+})(Inner || (Inner = {}));

tests/baselines/reference/TwoInternalModulesThatMergeEachWithExportedModulesOfTheSameName.js

@@ -39,14 +39,12 @@ var A;
 (function (A) {
     var B;
     (function (B) {
-        B.x;
     })(B = A.B || (A.B = {}));
 })(A || (A = {}));
 var A;
 (function (A) {
     var B;
     (function (B) {
-        B.x;
     })(B || (B = {}));
 })(A || (A = {}));
 // ensure the right var decl is exported

tests/baselines/reference/additionOperatorWithAnyAndEveryType.js

@@ -55,7 +55,6 @@ var E;
 })(E || (E = {}));
 var M;
 (function (M) {
-    M.a;
 })(M || (M = {}));
 var a;
 var b;

tests/baselines/reference/additionOperatorWithInvalidOperands.js

@@ -56,7 +56,6 @@ var E;
 })(E || (E = {}));
 var M;
 (function (M) {
-    M.a;
 })(M || (M = {}));
 var a;
 var b;

tests/baselines/reference/aliasUsedAsNameValue.js

@@ -19,7 +19,6 @@ export var a = function () {
 
 
 //// [aliasUsedAsNameValue_0.js]
-exports.id;
 //// [aliasUsedAsNameValue_1.js]
 function b(a) { return null; }
 exports.b = b;

tests/baselines/reference/assignmentCompatability2.js

@@ -19,7 +19,6 @@ var __test1__;
 })(__test1__ || (__test1__ = {}));
 var __test2__;
 (function (__test2__) {
-    __test2__.aa;
     ;
     __test2__.__val__aa = __test2__.aa;
 })(__test2__ || (__test2__ = {}));

tests/baselines/reference/assignmentCompatability25.js

@@ -19,7 +19,6 @@ var __test1__;
 })(__test1__ || (__test1__ = {}));
 var __test2__;
 (function (__test2__) {
-    __test2__.aa;
     ;
     __test2__.__val__aa = __test2__.aa;
 })(__test2__ || (__test2__ = {}));