Skip to content

Split out validators into a separate optional dependency project #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geota opened this issue Jan 30, 2015 · 3 comments
Open

Split out validators into a separate optional dependency project #142

geota opened this issue Jan 30, 2015 · 3 comments

Comments

@geota
Copy link

geota commented Jan 30, 2015

I am trying to use json-schema-validator in an Android app and am currently hitting the 65k dex method limit. Working on splitting my app into multiple dex, but was taking a look at json-schema-validator's dependencies and noticed the dependencies on joda-time and javax.mail.

Looks like you use joda-time to verify "datetime" format and javax.mail to verify the "email" format. Could these and the other validators be split out into an optional dependency package? Implementations are not required to provide implementations for the formats included in draftv4 of the spec. This would allow users of your library to choose if they want to include the format validators and perhaps promote users to contribute back custom validators that could be generally useful.

@geota
Copy link
Author

geota commented Aug 25, 2015

Has anyone been able to successfully use the validator in an Android app without hitting the dex method limit?

@pfaffenrodt
Copy link

We are facing the same problem. MultiDex is a pain. Let me know, if you found another solution.

To use this library in an android app this issue is critical. Removing dependencies would solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants