Skip to content

Commit ad84d1b

Browse files
committed
Remove eslint rules covered by dprint
1 parent 8d1c9d2 commit ad84d1b

11 files changed

+2
-824
lines changed

.eslintrc.json

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
},
1313
"plugins": [
1414
"@typescript-eslint",
15-
"jsdoc",
1615
"no-null",
1716
"import",
1817
"eslint-plugin-local"
@@ -32,9 +31,6 @@
3231
"@typescript-eslint/adjacent-overload-signatures": "error",
3332
"@typescript-eslint/array-type": "error",
3433

35-
"brace-style": "off",
36-
"@typescript-eslint/brace-style": ["error", "stroustrup", { "allowSingleLine": true }],
37-
3834
"@typescript-eslint/naming-convention": [
3935
"error",
4036
{ "selector": "typeLike", "format": ["PascalCase"], "filter": { "regex": "^(__String|[A-Za-z]+_[A-Za-z]+)$", "match": false } },
@@ -51,54 +47,30 @@
5147
"@typescript-eslint/consistent-type-definitions": ["error", "interface"],
5248
"@typescript-eslint/consistent-type-assertions": ["error", { "assertionStyle": "as" }],
5349

54-
"max-statements-per-line": ["error", { "max": 1 }],
55-
56-
"no-duplicate-imports": "off",
5750
"@typescript-eslint/no-duplicate-imports": "error",
5851

5952
"@typescript-eslint/no-inferrable-types": "error",
6053
"@typescript-eslint/no-misused-new": "error",
6154
"@typescript-eslint/no-this-alias": "error",
6255

63-
"no-unused-expressions": "off",
6456
"@typescript-eslint/no-unused-expressions": ["error", { "allowTernary": true }],
6557

6658
"@typescript-eslint/prefer-for-of": "error",
6759
"@typescript-eslint/prefer-function-type": "error",
6860
"@typescript-eslint/prefer-namespace-keyword": "error",
6961

70-
"quotes": "off",
71-
"@typescript-eslint/quotes": ["error", "double", { "avoidEscape": true, "allowTemplateLiterals": true }],
72-
73-
"semi": "off",
74-
"@typescript-eslint/semi": "error",
75-
76-
"space-before-function-paren": "off",
77-
"@typescript-eslint/space-before-function-paren": ["error", {
78-
"asyncArrow": "always",
79-
"anonymous": "always",
80-
"named": "never"
81-
}],
82-
8362
"@typescript-eslint/triple-slash-reference": "error",
84-
"@typescript-eslint/type-annotation-spacing": "error",
8563
"@typescript-eslint/unified-signatures": "error",
8664

87-
// TODO(jakebailey): remove this and other formatting related rules once dprint is enabled.
88-
"@typescript-eslint/comma-dangle": ["error", "always-multiline"],
89-
9065
// scripts/eslint/rules
91-
"local/object-literal-surrounding-space": "error",
92-
"local/no-type-assertion-whitespace": "error",
93-
"local/type-operator-spacing": "error",
66+
// TODO(jakebailey): no-double-space covers formatting of code that dprint handles, but also reads the text in comments.
67+
"local/no-double-space": "error",
9468
"local/only-arrow-functions": ["error", {
9569
"allowNamedFunctions": true,
9670
"allowDeclarations": true
9771
}],
98-
"local/no-double-space": "error",
9972
"local/boolean-trivia": "error",
10073
"local/no-in-operator": "error",
101-
"local/simple-indent": "error",
10274
"local/debug-assert": "error",
10375
"local/no-keywords": "error",
10476
"local/one-namespace-per-file": "error",
@@ -109,16 +81,11 @@
10981
// eslint-plugin-no-null
11082
"no-null/no-null": "error",
11183

112-
// eslint-plugin-jsdoc
113-
"jsdoc/check-alignment": "error",
114-
11584
// eslint
11685
"constructor-super": "error",
117-
"curly": ["error", "multi-line"],
11886
"dot-notation": "error",
11987
"eqeqeq": "error",
12088
"linebreak-style": ["error", "windows"],
121-
"new-parens": "error",
12289
"no-caller": "error",
12390
"no-duplicate-case": "error",
12491
"no-empty": "error",
@@ -132,7 +99,6 @@
13299
"no-sparse-arrays": "error",
133100
"no-template-curly-in-string": "error",
134101
"no-throw-literal": "error",
135-
"no-trailing-spaces": "error",
136102
"no-undef-init": "error",
137103
"no-unsafe-finally": "error",
138104
"no-unused-labels": "error",
@@ -141,7 +107,6 @@
141107
"prefer-const": "error",
142108
"prefer-object-spread": "error",
143109
"quote-props": ["error", "consistent-as-needed"],
144-
"space-in-parens": "error",
145110
"unicode-bom": ["error", "never"],
146111
"use-isnan": "error"
147112
}

package-lock.json

Lines changed: 0 additions & 92 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@
7272
"eslint": "^8.22.0",
7373
"eslint-formatter-autolinkable-stylish": "^1.2.0",
7474
"eslint-plugin-import": "^2.26.0",
75-
"eslint-plugin-jsdoc": "^39.3.6",
7675
"eslint-plugin-local": "^1.0.0",
7776
"eslint-plugin-no-null": "^1.0.2",
7877
"fancy-log": "latest",

scripts/eslint/rules/no-type-assertion-whitespace.js

Lines changed: 0 additions & 43 deletions
This file was deleted.

scripts/eslint/rules/object-literal-surrounding-space.js

Lines changed: 0 additions & 72 deletions
This file was deleted.

0 commit comments

Comments
 (0)