Skip to content

Commit a2bb6c6

Browse files
committed
Don't check needsUpdate for localize, now that it is fast
1 parent c7de568 commit a2bb6c6

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

Herebyfile.mjs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import esbuild from "esbuild";
66
import { task } from "hereby";
77
import _glob from "glob";
88
import util from "util";
9-
import { exec, readJson, needsUpdate, getDiffTool, getDirSize } from "./scripts/build/utils.mjs";
9+
import { exec, readJson, getDiffTool, getDirSize } from "./scripts/build/utils.mjs";
1010
import { runConsoleTests, refBaseline, localBaseline, refRwcBaseline, localRwcBaseline } from "./scripts/build/tests.mjs";
1111
import { buildProject as realBuildProject, cleanProject } from "./scripts/build/projects.mjs";
1212
import { localizationDirectories } from "./scripts/build/localization.mjs";
@@ -148,15 +148,12 @@ const localizationTargets = localizationDirectories
148148
.map(f => `built/local/${f}/diagnosticMessages.generated.json`)
149149
.concat(generatedLCGFile);
150150

151-
const localize = task({
151+
export const localize = task({
152152
name: "localize",
153153
dependencies: [generateDiagnostics],
154154
run: async () => {
155155
await fs.promises.mkdir("./built/local", { recursive: true }); // TODO(jakebailey): needed?
156-
if (needsUpdate(diagnosticMessagesGeneratedJson, generatedLCGFile)) {
157-
// TODO(jakebailey): slow; need needsUpdate to not block the builds
158-
return exec(process.execPath, ["scripts/generateLocalizedDiagnosticMessages.mjs", "src/loc/lcl", "built/local", diagnosticMessagesGeneratedJson], { ignoreExitCode: true });
159-
}
156+
return exec(process.execPath, ["scripts/generateLocalizedDiagnosticMessages.mjs", "src/loc/lcl", "built/local", diagnosticMessagesGeneratedJson], { ignoreExitCode: true });
160157
}
161158
});
162159

0 commit comments

Comments
 (0)