Skip to content

Commit bb5d5a6

Browse files
volosiedmarkt-asf
authored andcommitted
Address review comments
Use re-use Revert back to implementor Use reenable
1 parent 8809042 commit bb5d5a6

File tree

8 files changed

+14
-14
lines changed

8 files changed

+14
-14
lines changed

api/client/src/main/java/jakarta/websocket/ClientEndpointConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public interface ClientEndpointConfig extends EndpointConfig {
5959
* Return the SSLContext to be used to establish a WebSocket (wss) connection to the server. The SSLContext will
6060
* have initialised. For insecure WebSocket (ws) connections, this will be {@code null}. If there is an existing
6161
* connection to the server that uses the same SSLContext and that connection supports multiplexing WebSocket
62-
* connections then the container may choose to reuse that connection rather than creating a new one. Containers
62+
* connections then the container may choose to re-use that connection rather than creating a new one. Containers
6363
* may provide container specific configuration to control this behaviour.
6464
*
6565
* @return the SSLContext to use to establish a secure connection to the server or {@code null} if an insecure
@@ -235,7 +235,7 @@ public ClientEndpointConfig.Builder decoders(List<Class<? extends Decoder>> deco
235235
/**
236236
* Assign the SSLContext to be used when connection to the WebSocket server. If there is an existing connection
237237
* to the server that uses the same SSLContext and that connection supports multiplexing WebSocket connections
238-
* then the container may choose to reuse that connection rather than creating a new one. Containers may
238+
* then the container may choose to re-use that connection rather than creating a new one. Containers may
239239
* provide container specific configuration to control this behaviour.
240240
*
241241
* @param sslContext The SSLContext which must be initialised for secure WebSocket (wss) connections or

api/client/src/main/java/jakarta/websocket/DefaultClientEndpointConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public List<Class<? extends Decoder>> getDecoders() {
9494
/**
9595
* SSLContext to use to secure WebSocket (wss) connections or {@code null} for insecure Websocket (ws) connections.
9696
* If there is an existing connection to the server that uses the same SSLContext and that connection supports
97-
* multiplexing WebSocket connections then the container may choose to reuse that connection rather than creating a
97+
* multiplexing WebSocket connections then the container may choose to re-use that connection rather than creating a
9898
* new one. Containers may provide container specific configuration to control this behaviour.
9999
*
100100
* @since WebSocket 2.1

spec/src/main/asciidoc/WebSocket.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ WebSocket implementation must preserve this session data for later
194194
access until the completion of the *onClose()* method on the endpoint
195195
instance [WSC 2.1.2-2]. After that time, the WebSocket implementation
196196
is permitted to discard the developer data. A WebSocket implementation
197-
that chooses to pool *Session* instances may at that point reuse the
197+
that chooses to pool *Session* instances may at that point re-use the
198198
same *Session* instance to represent a new connection provided it issues
199199
a new unique *Session* id [WSC 2.1.2-3].
200200

@@ -686,7 +686,7 @@ establish a secure WebSocket (wss) connection or an insecure WebSocket (ws)
686686
connection if the provided `SSLContext` is `null`. If there is an existing
687687
connection to the server that uses the same SSLContext and that connection
688688
supports multiplexing WebSocket connections then the container may choose to
689-
reuse that connection rather than creating a new one. Containers may provide
689+
re-use that connection rather than creating a new one. Containers may provide
690690
container specific configuration to control this behaviour.
691691

692692
[[client-configuration-modification]]

spec/src/main/theme/jakartaee-theme.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ example:
190190
border_radius: $base_border_radius
191191
border_width: 0.75
192192
background_color: ffffff
193-
# FIXME re-enable padding bottom once margin collapsing is implemented
193+
# FIXME reenable padding bottom once margin collapsing is implemented
194194
padding: [$vertical_rhythm, $horizontal_rhythm, 0, $horizontal_rhythm]
195195
image:
196196
align: left
@@ -202,7 +202,7 @@ sidebar:
202202
border_color: e1e1e1
203203
border_radius: $base_border_radius
204204
border_width: $base_border_width
205-
# FIXME re-enable padding bottom once margin collapsing is implemented
205+
# FIXME reenable padding bottom once margin collapsing is implemented
206206
padding: [$vertical_rhythm, $vertical_rhythm * 1.25, 0, $vertical_rhythm * 1.25]
207207
title:
208208
align: center

tck/docs/userguide/src/main/asciidoc/book.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
= TCK User's Guide for Technology Implementers
1+
= TCK User's Guide for Technology Implementors
22

33
include::title.adoc[]
44

tck/docs/userguide/src/main/asciidoc/intro.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ to deploy them across heterogeneous computing environments without
5656
porting.
5757
* Compatibility testing allows application users to obtain applications
5858
from disparate sources and deploy them with confidence.
59-
* Conformance testing benefits Jakarta platform implementers by ensuring a
59+
* Conformance testing benefits Jakarta platform implementors by ensuring a
6060
level playing field for all Jakarta platform ports.
6161
6262
[[GBFPR]][[tck-compatibility-rules]]

tck/docs/userguide/src/main/asciidoc/rules.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,8 @@ include::rules.inc[]
297297
~~~~~~~~~~~~~~~~~~~~~~~~
298298

299299
Jakarta has a well established process for managing challenges to its
300-
TCKs. Any implementer may submit a challenge to one or more tests in the
301-
{TechnologyShortName} TCK as it relates to their implementation. Implementer
300+
TCKs. Any implementor may submit a challenge to one or more tests in the
301+
{TechnologyShortName} TCK as it relates to their implementation. Implementor
302302
means the entity as a whole in charge of producing the final certified release.
303303
*Challenges filed should represent the consensus of that entity*.
304304

@@ -358,7 +358,7 @@ A consensus that a test produces invalid results will result in the exclusion of
358358
4. Rejected Challenges and Remedy. +
359359
When a`challenge` issue is rejected, it must be closed with a label of `invalid` to indicate it has been rejected.
360360
There appeal process for challenges rejected on technical terms is outlined in Escalation Appeal.
361-
If, however, an implementer feels the TCK challenge process was not followed, an appeal issue should be filed with specification project’s TCK issue tracker using the label `challenge-appeal`.
361+
If, however, an implementor feels the TCK challenge process was not followed, an appeal issue should be filed with specification project’s TCK issue tracker using the label `challenge-appeal`.
362362
A project lead should escalate the issue with the Jakarta EE Specification Committee via email ([email protected]).
363363
The committee will evaluate the matter purely in terms of due process.
364364
If the appeal is accepted, the original TCK challenge issue will be reopened and a label of `appealed-challenge` added, along with a discussion of the appeal decision, and the `challenge-appeal` issue with be closed.

tck/docs/userguide/src/theme/jakartaee-theme.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ example:
190190
border_radius: $base_border_radius
191191
border_width: 0.75
192192
background_color: ffffff
193-
# FIXME re-enable padding bottom once margin collapsing is implemented
193+
# FIXME reenable padding bottom once margin collapsing is implemented
194194
padding: [$vertical_rhythm, $horizontal_rhythm, 0, $horizontal_rhythm]
195195
image:
196196
align: left
@@ -202,7 +202,7 @@ sidebar:
202202
border_color: e1e1e1
203203
border_radius: $base_border_radius
204204
border_width: $base_border_width
205-
# FIXME re-enable padding bottom once margin collapsing is implemented
205+
# FIXME reenable padding bottom once margin collapsing is implemented
206206
padding: [$vertical_rhythm, $vertical_rhythm * 1.25, 0, $vertical_rhythm * 1.25]
207207
title:
208208
align: center

0 commit comments

Comments
 (0)