Test fixtures 413 #421
Test fixtures 413 #421
Conversation
|
Also, removes reliance on diff to check output for regressions. |
|
Assuming no test failures (or only due to #422) this PR should be ready to merge. If you have any questions, or need more info, LMK. |
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 3 3
Lines 5305 5305
=======================================
Hits 4749 4749
Misses 556 556 |
|
@jacobwilliams let me know if there's anything you want me to explain or cleanup. Otherwise, I believe that this is ready to merge. |
CMakeLists.txt
Outdated
| @@ -14,6 +14,9 @@ cmake_minimum_required ( VERSION 2.8.8 FATAL_ERROR ) | |||
| # Use MSVS folders to organize projects on windows | |||
| set_property(GLOBAL PROPERTY USE_FOLDERS ON) | |||
|
|
|||
| option(JSON_FORTRAN_USE_OpenCoarrays | |||
| "Build VTKmofo with support for linking against OpenCoarray programs" OFF) | |||
There was a problem hiding this comment.
Derp.... I saw that and meant to fix it but then lost track of it. (https://github.com/porteri/vtkmofo)
|
Do we need the OpenCoarrays stuff in the Cmake file? If it's useful we can keep it, can you provide me with some text I can put in the release notes explaining what that is for? |
|
Can you pull latest master to get the change from #422? |
The problem arises when you have a coarray code and you want to link JSON-Fortran. If JSON-Fortran is compiled without |
- Fixes jacobwilliams#413 - Also fixes regression testing and output validation
zbeekman
force-pushed
the
test-fixtures-413
branch
from
11c1e8d to
2ddc226
Compare
- Passing `-fcoarray=lib` to gfortran causes the compiler to generate different modules & symbols. This is likely a bug in gfortran, but, a consequence is that you need to build libraries you link to with the same `-fcoarray=...` flag.
zbeekman
force-pushed
the
test-fixtures-413
branch
from
2ddc226 to
a7e7978
Compare
| as the coarray runtime implementation. Use the | ||
| `-DJSON_FORTRAN_USE_OpenCoarrays:BOOL=ON` option to cmake to enable | ||
| this. (NOTE: The fact that this is required may be a bug in | ||
| GFortran.) |
There was a problem hiding this comment.
@jacobwilliams how's this for the explanation? If you prefer, I can remove this option and users can manually tweak CMake flags if they need to.
There was a problem hiding this comment.
That sounds fine. I don't mind keeping it if it's useful.
Fixes #413
Also, re-enables & fixes some validation of outputs created by unit tests.