Skip to content

Some efficiency improvements when parsing strings. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 23, 2018

Conversation

jacobwilliams
Copy link
Owner

@jacobwilliams jacobwilliams commented Jul 20, 2018

Fixes #351
Fixes #353
Fixes #354
Fixes #355
Fixes #356
Fixes #357

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #352 into master will increase coverage by 0.1%.
The diff coverage is 79.51%.

@@            Coverage Diff            @@
##           master     #352     +/-   ##
=========================================
+ Coverage   87.68%   87.79%   +0.1%     
=========================================
  Files           3        3             
  Lines        4556     4562      +6     
=========================================
+ Hits         3995     4005     +10     
+ Misses        561      557      -4

…dation. Some adjustments to error messages for invalid hex. Fixes #354

An exception is now raised for a string that ends in an escape character. Fixes #353
…Fixes #355

Reverted an inadvertent regression in the previous commit.
The arguments to json_file_check_for_errors are now optional to match the core routine. Fixes #356
Added some workaround in the error checking routine to gfortran bugs.
… have unit test 6 pass on all platforms.

updated gitignore file for intel on windows.
@jacobwilliams jacobwilliams merged commit b833711 into master Jul 23, 2018
@jacobwilliams jacobwilliams deleted the 351-string-speedup branch July 23, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants