Skip to content

Commit f1d796f

Browse files
Fix swarm.closeConns
1 parent a73066b commit f1d796f

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"code": "^1.4.1",
3232
"lab": "^5.13.0",
3333
"precommit-hook": "^3.0.0",
34+
"sinon": "^1.15.4",
3435
"standard": "^4.5.2",
3536
"stream-pair": "^1.0.3"
3637
},

src/swarm.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ function Swarm () {
150150
if (number === 0) { cb() }
151151
var c = new Counter(number, cb)
152152

153-
keys.map(function (key) {
154-
c.hit()
153+
keys.forEach(function (key) {
155154
self.connections[key].conn.end()
155+
c.hit()
156156
})
157157
}
158158

tests/swarm-test.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var Lab = require('lab')
22
var Code = require('code')
3+
var sinon = require('sinon')
34
var lab = exports.lab = Lab.script()
45

56
var experiment = lab.experiment
@@ -85,6 +86,19 @@ experiment('BASICS', function () {
8586
})
8687
})
8788
})
89+
90+
experiment('Swarm.closeConns', function () {
91+
test('calls end on all connections', function (done) {
92+
swarmA.openConnection(peerB, function () {
93+
var key = Object.keys(swarmA.connections)[0]
94+
sinon.spy(swarmA.connections[key].conn, 'end')
95+
swarmA.closeConns(function () {
96+
expect(swarmA.connections[key].conn.end.called).to.be.equal(true)
97+
done()
98+
})
99+
})
100+
})
101+
})
88102
})
89103

90104
experiment('BASE', function () {

0 commit comments

Comments
 (0)