Skip to content

Add pre-commit hooks #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add pre-commit hooks #617

wants to merge 5 commits into from

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jun 26, 2022

Related to #615, also simplifies Packer and Terraform installation, and deletes the @restyled-commits configuration. Note that pre-commit hooks are slow, really and painfully slow, and may get in the way of developers.

And there is also golangci/golangci-lint#1245

@0x2b3bfa0 0x2b3bfa0 added the testing Unit tests & debugging label Jun 26, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 26, 2022
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review July 1, 2022 23:11
@0x2b3bfa0 0x2b3bfa0 requested a review from a team July 1, 2022 23:11
@0x2b3bfa0
Copy link
Member Author

Closed in favor of #623 and #624. Hooks take tens of seconds to run and are detrimental to development experience.

@0x2b3bfa0 0x2b3bfa0 closed this Jul 5, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the hooks branch July 5, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Unit tests & debugging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant