Skip to content

Doc clarifications #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Doc clarifications #365

merged 3 commits into from
Feb 13, 2018

Conversation

frankbu
Copy link
Contributor

@frankbu frankbu commented Feb 8, 2018

No description provided.

@frankbu frankbu requested a review from rshriram February 8, 2018 20:54
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 8, 2018
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Feb 9, 2018
@rshriram rshriram added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Feb 9, 2018
@frankbu
Copy link
Contributor Author

frankbu commented Feb 12, 2018

/retest

@rshriram rshriram merged commit 145be48 into master Feb 13, 2018
@frankbu frankbu deleted the gateway-clarifications branch February 13, 2018 19:35
ayj pushed a commit to ayj/api that referenced this pull request Feb 14, 2018
* Doc clarifications

* regenerate go files
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
* Added service_configs map to server config

* Defined message ServiceConfigTrafficPercentage

* Removed config_id from the ServerConfig

* Removed deprecated comment

* Removed the service_name

* Applied service_config.proto changes, disabled config_manager
nacx pushed a commit to nacx/api that referenced this pull request Apr 15, 2020
This provides the skeleton for `ResourcesService`. This supersedes tetrateio/tetrate#326.

An example of calling `SetResource` showing the involved components is as follows:

![image](https://user-images.githubusercontent.com/73152/51816698-66994580-22fa-11e9-8247-5a92395ee236.png)

Mirrored from https://github.com/tetrateio/tetrate @ 1c1e5710727edb22a1a853b6b06691b974a760c0
nacx added a commit to nacx/api that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants