-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Description
Looking at the latest Istio CRDs, I notice that storage version for the CRDs is not v1 e.g. for DestinationRule CRD the storage version (version used for saving resource in storage) is v1beta1. Is there a reason for not having set v1 as new storage version?
I am asking because it seems that Istio CRs will continue to be stored in non-stable version based on conversion mechanism of Kubernetes, see https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#writing-reading-and-updating-versioned-customresourcedefinition-objects
"When an object is written, it is stored at the version designated as the storage version at the time of the write. If the storage version changes, existing objects are never converted automatically. However, newly-created or updated objects are written at the new storage version. It is possible for an object to have been written at a version that is no longer served."
Had a discussion with @keithmattix , and looks like as per https://docs.google.com/document/d/1onST4-swbZE1UPCDMQm1c7T5rzYEn7Wo4uFNShz0kNw/edit?tab=t.0 this was already discussed, and the plan was to wait for some more time before doing the storage version migration.
Now that a few releases have passed with the CRD version updates, maybe it is time to do the storage version migration too?
Version
master
Additional Information
No response
Affected product area
- Ambient
- Docs
- Dual Stack
- Installation
- Networking
- Performance and Scalability
- Extensions and Telemetry
- Security
- Test and Release
- User Experience
- Developer Infrastructure
- Upgrade
- Multi Cluster
- Virtual Machine
- Control Plane Revisions