feat: Add Logical Replication Tests for v3 #121
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 87.42% 87.28% -0.15%
==========================================
Files 29 29
Lines 2498 2500 +2
==========================================
- Hits 2184 2182 -2
- Misses 314 318 +4
☔ View full report in Codecov by Sentry. |
|
@osaxma: could you please rebase this PR now? |
|
@isoos The tests that I added aren't passing locally (by the way, this PR only add these tests and nothing else) I'll try to fix it today. |
osaxma
changed the title
osaxma
changed the title
osaxma
force-pushed
the
implement_replication_to_v3
branch
from
a620c80 to
f20bac1
Compare
| case CopyBothResponseMessage(): | ||
| // This message indicates a successful start for Streaming Replication. | ||
| // Hence, in this context, the query is complete. And from here on, | ||
| // the server will be streaming replication messages. | ||
| // But if the connection was used after this point to execute further | ||
| // queries, the server messages will be blocked. | ||
| // TODO(osaxma): Prevent executing queries when Streaming Replication | ||
| // is ongoing | ||
| await _completeQuery(); |
There was a problem hiding this comment.
This is a temporary special case for Streaming Replication since CopyBothResponseMessage is only used for that. Ideally, we should stop any queries from being executed after this point to prevent blocking the server messages.
I will try updating the example repository for Steaming Replication to investigate what could go wrong and how to better handle this.
CopyBothResponseMessagecase in message handler