-
Notifications
You must be signed in to change notification settings - Fork 19
Feat: wrap AudioBuffer with JS proxy #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -40,6 +41,10 @@ ${d.nodes.map(n => ` ${d.name(n)},`).join('\n')} | |||
} | |||
} | |||
|
|||
createBuffer(numberOfChannels, length, sampleRate) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have this constructor option supported
@@ -0,0 +1,20 @@ | |||
|
|||
exports.toSanitizedSequence = function toSanitizedSequence(data, targetCtor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally... for nothing in this PR :) but I was thinking copyFromChannel
and copyToChannel
had the same API as for example https://webaudio.github.io/web-audio-api/#dom-baseaudiocontext-createiirfilter which support any kind of floating point value sequence, e.g. Array, Float32Array, Float64Array (numbers is JS are basically only double
)
Should be useful later I hope/imagine
Just realized there is an issue with |
Ok I made the changes, but wpt results are a bit disturbing... (all are made against rust upstream/main)
|
Without looking into it, I just want to comment it is possible to both decrease in success and fail. I'm using the following trick to digest the results better: (make sure to run create file
dissect the full suite per directory: |
Ah thanks! |
Ok, finally got it working, it was a bit more complex than expected but paves the way for #84 main
feat/Audiobuffer-proxy
|
Cool! |
Before
After
(w/ orottier/web-audio-api-rs#463)