fix: handle OscillatorNode custom type special cases

Author: b-ma

generator/js/AudioNodes.tmpl.js

@@ -197,6 +197,21 @@ module.exports = (jsExport, nativeBinding) => {
           return checkMember;
         }).join('');
 
+        // handle spacial cases
+        if (d.name(d.node) === 'OscillatorNode') {
+          // https://webaudio.github.io/web-audio-api/#dom-oscillatoroptions-type
+          checkOptions += `
+      if (parsedOptions.type === 'custom' && parsedOptions.periodicWave === null) {
+        throw new DOMException("Failed to construct 'OscillatorNode': A PeriodicWave must be specified if the type is set to 'custom'", 'InvalidStateError');
+      }
+
+      if (parsedOptions.periodicWave !== null) {
+        parsedOptions.type = 'custom';
+      }
+
+          `;
+        }
+
         return checkOptions;
       }())}
 

js/OscillatorNode.js

@@ -101,6 +101,14 @@ module.exports = (jsExport, nativeBinding) => {
         parsedOptions.periodicWave = null;
       }
 
+      if (parsedOptions.type === 'custom' && parsedOptions.periodicWave === null) {
+        throw new DOMException('Failed to construct \'OscillatorNode\': A PeriodicWave must be specified if the type is set to \'custom\'', 'InvalidStateError');
+      }
+
+      if (parsedOptions.periodicWave !== null) {
+        parsedOptions.type = 'custom';
+      }
+
       let napiObj;
 
       try {

js/lib/errors.js

@@ -6,40 +6,40 @@ const internalRe = new RegExp(internalPath);
 
 // from wpt/resources/tesharness.js (line 2226)
 const nameCodeMap = {
-    IndexSizeError: 1,
-    HierarchyRequestError: 3,
-    WrongDocumentError: 4,
-    InvalidCharacterError: 5,
-    NoModificationAllowedError: 7,
-    NotFoundError: 8,
-    NotSupportedError: 9,
-    InUseAttributeError: 10,
-    InvalidStateError: 11,
-    SyntaxError: 12,
-    InvalidModificationError: 13,
-    NamespaceError: 14,
-    InvalidAccessError: 15,
-    TypeMismatchError: 17,
-    SecurityError: 18,
-    NetworkError: 19,
-    AbortError: 20,
-    URLMismatchError: 21,
-    QuotaExceededError: 22,
-    TimeoutError: 23,
-    InvalidNodeTypeError: 24,
-    DataCloneError: 25,
-
-    EncodingError: 0,
-    NotReadableError: 0,
-    UnknownError: 0,
-    ConstraintError: 0,
-    DataError: 0,
-    TransactionInactiveError: 0,
-    ReadOnlyError: 0,
-    VersionError: 0,
-    OperationError: 0,
-    NotAllowedError: 0,
-    OptOutError: 0
+  IndexSizeError: 1,
+  HierarchyRequestError: 3,
+  WrongDocumentError: 4,
+  InvalidCharacterError: 5,
+  NoModificationAllowedError: 7,
+  NotFoundError: 8,
+  NotSupportedError: 9,
+  InUseAttributeError: 10,
+  InvalidStateError: 11,
+  SyntaxError: 12,
+  InvalidModificationError: 13,
+  NamespaceError: 14,
+  InvalidAccessError: 15,
+  TypeMismatchError: 17,
+  SecurityError: 18,
+  NetworkError: 19,
+  AbortError: 20,
+  URLMismatchError: 21,
+  QuotaExceededError: 22,
+  TimeoutError: 23,
+  InvalidNodeTypeError: 24,
+  DataCloneError: 25,
+
+  EncodingError: 0,
+  NotReadableError: 0,
+  UnknownError: 0,
+  ConstraintError: 0,
+  DataError: 0,
+  TransactionInactiveError: 0,
+  ReadOnlyError: 0,
+  VersionError: 0,
+  OperationError: 0,
+  NotAllowedError: 0,
+  OptOutError: 0,
 };
 
 exports.nameCodeMap = nameCodeMap;