fix: properly handle setting buffer to null in AudioNode ctors

Author: b-ma

generator/rs/audio_nodes.tmpl.rs

@@ -250,10 +250,18 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
                                     // AudioBuffer, PeriodicWave
                                     case 'interface':
                                         return `
-                    let some_${simple_slug}_js = options_js.get::<&str, JsObject>("${m.name}")?;
+                    let some_${simple_slug}_js = options_js.get::<&str, JsUnknown>("${m.name}")?;
                     let ${slug} = if let Some(${simple_slug}_js) = some_${simple_slug}_js {
-                        let ${simple_slug}_napi = ctx.env.unwrap::<${d.napiName(idl)}>(&${simple_slug}_js)?;
-                        Some(${simple_slug}_napi.unwrap().clone())
+                        // nullable options
+                        match ${simple_slug}_js.get_type()? {
+                            ValueType::Object => {
+                                let ${simple_slug}_js = ${simple_slug}_js.coerce_to_object()?;
+                                let ${simple_slug}_napi = ctx.env.unwrap::<${d.napiName(idl)}>(&${simple_slug}_js)?;
+                                Some(${simple_slug}_napi.unwrap().clone())
+                            },
+                            ValueType::Null => None,
+                            _ => unreachable!(),
+                        }
                     } else {
                         None
                     };

src/audio_buffer_source_node.rs

@@ -146,10 +146,18 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
     let options = if let Ok(either_options) = ctx.try_get::<JsObject>(1) {
         match either_options {
             Either::A(options_js) => {
-                let some_buffer_js = options_js.get::<&str, JsObject>("buffer")?;
+                let some_buffer_js = options_js.get::<&str, JsUnknown>("buffer")?;
                 let buffer = if let Some(buffer_js) = some_buffer_js {
-                    let buffer_napi = ctx.env.unwrap::<NapiAudioBuffer>(&buffer_js)?;
-                    Some(buffer_napi.unwrap().clone())
+                    // nullable options
+                    match buffer_js.get_type()? {
+                        ValueType::Object => {
+                            let buffer_js = buffer_js.coerce_to_object()?;
+                            let buffer_napi = ctx.env.unwrap::<NapiAudioBuffer>(&buffer_js)?;
+                            Some(buffer_napi.unwrap().clone())
+                        }
+                        ValueType::Null => None,
+                        _ => unreachable!(),
+                    }
                 } else {
                     None
                 };

src/convolver_node.rs

@@ -130,10 +130,18 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
     let options = if let Ok(either_options) = ctx.try_get::<JsObject>(1) {
         match either_options {
             Either::A(options_js) => {
-                let some_buffer_js = options_js.get::<&str, JsObject>("buffer")?;
+                let some_buffer_js = options_js.get::<&str, JsUnknown>("buffer")?;
                 let buffer = if let Some(buffer_js) = some_buffer_js {
-                    let buffer_napi = ctx.env.unwrap::<NapiAudioBuffer>(&buffer_js)?;
-                    Some(buffer_napi.unwrap().clone())
+                    // nullable options
+                    match buffer_js.get_type()? {
+                        ValueType::Object => {
+                            let buffer_js = buffer_js.coerce_to_object()?;
+                            let buffer_napi = ctx.env.unwrap::<NapiAudioBuffer>(&buffer_js)?;
+                            Some(buffer_napi.unwrap().clone())
+                        }
+                        ValueType::Null => None,
+                        _ => unreachable!(),
+                    }
                 } else {
                     None
                 };

src/oscillator_node.rs

@@ -166,11 +166,19 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
                     0.
                 };
 
-                let some_periodic_wave_js = options_js.get::<&str, JsObject>("periodicWave")?;
+                let some_periodic_wave_js = options_js.get::<&str, JsUnknown>("periodicWave")?;
                 let periodic_wave = if let Some(periodic_wave_js) = some_periodic_wave_js {
-                    let periodic_wave_napi =
-                        ctx.env.unwrap::<NapiPeriodicWave>(&periodic_wave_js)?;
-                    Some(periodic_wave_napi.unwrap().clone())
+                    // nullable options
+                    match periodic_wave_js.get_type()? {
+                        ValueType::Object => {
+                            let periodic_wave_js = periodic_wave_js.coerce_to_object()?;
+                            let periodic_wave_napi =
+                                ctx.env.unwrap::<NapiPeriodicWave>(&periodic_wave_js)?;
+                            Some(periodic_wave_napi.unwrap().clone())
+                        }
+                        ValueType::Null => None,
+                        _ => unreachable!(),
+                    }
                 } else {
                     None
                 };