This repository was archived by the owner on Aug 11, 2021. It is now read-only.
This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Any chance of moving to js-sha3? #3
Open
Description
Currently, this module brings in a Native dep [email protected]. Would it be possible to move to js-sha3, the same used in js-multihashing-async, so that it doesn't represent a blocker for js-ipfs electron users
> [email protected] install /Users/koruza/code/js-ipld-eth-star/node_modules/fsevents
> node install
[fsevents] Success: "/Users/koruza/code/js-ipld-eth-star/node_modules/fsevents/lib/binding/Release/node-v51-darwin-x64/fse.node" is installed via remote
> [email protected] install /Users/koruza/code/js-ipld-eth-star/node_modules/sha3
> node-gyp rebuild
CXX(target) Release/obj.target/sha3/src/addon.o
../src/addon.cpp:59:36: warning: 'NewInstance' is deprecated [-Wdeprecated-declarations]
info.GetReturnValue().Set(cons->NewInstance(argc, argv));
^
/Users/koruza/.node-gyp/7.10.0/include/node/v8.h:3658:31: note: 'NewInstance' has been explicitly marked deprecated
here
Local<Object> NewInstance(int argc, Local<Value> argv[]) const);
^
1 warning generated.
CXX(target) Release/obj.target/sha3/src/displayIntermediateValues.o
CXX(target) Release/obj.target/sha3/src/KeccakF-1600-reference.o
CXX(target) Release/obj.target/sha3/src/KeccakNISTInterface.o
CXX(target) Release/obj.target/sha3/src/KeccakSponge.o
SOLINK_MODULE(target) Release/sha3.node
> [email protected] install /Users/koruza/code/js-ipld-eth-star/node_modules/keccak
> prebuild-install || node-gyp rebuild || echo "Keccak bindings compilation fail. Pure JS implementation will be used."
Thanks!