This repository was archived by the owner on Feb 12, 2024. It is now read-only.
chore: allow bundlesize gh action to fail #3700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's because there's a duplicate dep version that needs to be fixed. Usually it's because some transitive dep increases it's bundle size by a kilobyte or two and has nothing to do with the current PR, so all we do is increase the bundlesizeMax value to make it pass. Let's just make the check informational instead.
lidel
reviewed
May 25, 2021
There was a problem hiding this comment.
Sounds sensible.
Should we upstream this to https://github.com/ipfs/aegir/blob/master/md/github-actions.md? (cc @hugomrdias)?
|
I'm not sure about that - we tend to get the most outside contributions on this repo so it's useful to reduce contributor friction here, but possibly less so for other repos in the stack? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's because there's a duplicate dep version that needs to
be fixed.
Usually it's because some transitive dep increases it's bundle size
by a kilobyte or two and has nothing to do with the current PR, so all
we do is increase the
bundlesizeMaxvalue to make it pass.Let's just make the check informational instead.