This repository was archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Jan 29, 2020
achingbrain
reviewed
Jan 30, 2020
.travis.yml
Outdated
@@ -81,6 +81,7 @@ jobs: | |||
- export IPFS_JS_EXEC=`pwd`/src/cli/bin.js | |||
- export IPFS_REUSEPORT=false | |||
- cd node_modules/ipfs-interop | |||
- npm install go-ipfs-dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is in the devDependencies
map, these lines can be removed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they can now yes
Closing as dependencies are all being upgraded here #2729 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
go-ipfs-dep
todevDependencies
. See https://github.com/ipfs/interface-js-ipfs-core/issues/582#issuecomment-580215033Also
cherry pickscopy pastes a fix from 2b6f0e9 to ensure our peer ID is not double suffixed onto our swarm addresses.