-
Notifications
You must be signed in to change notification settings - Fork 31
fix: request body type #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two problems: 1. The import for `NodeReadableStream` was missing 2. We can't use `NodeReadableStream` as the type for `body` because it it not assignable to any type that makes up `BodyInit` so instead [modify](https://stackoverflow.com/questions/41285211/overriding-interface-property-type-defined-in-typescript-d-ts-file) the RequestInit type to omit the original `body` type and include the new one.
hugomrdias
approved these changes
Jun 12, 2021
Gozala
reviewed
Jun 14, 2021
Gozala
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mode some suggestions, but works as is too
src/types.d.ts
Outdated
export interface FetchOptions extends RequestInit { | ||
type Modify<T, R> = Omit<T, keyof R> & R | ||
|
||
export type FetchOptions = Modify<RequestInit, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think following would be more obvious.
export type FetchOptions = Override<RequestInit, { body?: ... }> & {
...
}
achingbrain
commented
Jun 17, 2021
Co-authored-by: Irakli Gozalishvili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two problems:
NodeReadableStream
was missingNodeReadableStream
as the type forbody
because it it not assignable to any type that makes upBodyInit
so instead modify the RequestInit type to omit the originalbody
type and include the new one.Fixes this error: