feat: trying to callbackify ipfs-repo #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This callbackified ipfs-repo. Almost all tests pass, except the ones for custom locking. Though when used with js-ipfs, the js-ipfs tests won't work. It seems that starting up a node is stuck somewhere.
|
I’ll take a look at the js-ipfs tests. |
|
I think I know what's going on... My build of js-ipfs with this branch of ipfs-repo was getting stuck starting mfs because it's using ipfs-mfs 0.12.2 ... which doesn't have the following changes: ipfs-inactive/js-ipfs-mfs@c21e032 If I use ipfs-mfs from the master git branch, more tests run. I tweaked package.json to build it from master: |
|
Here's a fix for some of the failing tests. I'll look at the other ones tomorrow. |
|
Since ipfs/js-ipfs#2390 was merged, is this still necessary? |
|
This is no longer necessary as we are full async/await everywhere now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This callbackified ipfs-repo. Almost all tests pass, except the ones for
custom locking.
Though when used with js-ipfs, the js-ipfs tests won't work. It seems
that starting up a node is stuck somewhere.