Cleanup for dev review

Author: dignifiedquire

package.json

@@ -8,7 +8,7 @@
     "test:node": "dignified-test node",
     "test:browser": "dignified-test browser",
     "build": "dignified-build",
-    "coverage": "istanbul cover --print both -- _mocha test/node.js",
+    "coverage": "dignified-coverage",
     "lint": "dignified-lint",
     "release": "dignified-release"
   },
@@ -33,7 +33,6 @@
     "dignified.js": "^1.0.0",
     "fs-blob-store": "^5.2.1",
     "idb-plus-blob-store": "^1.0.0",
-    "istanbul": "^0.4.2",
     "local-storage-blob-store": "0.0.3",
     "lodash": "^4.6.1",
     "ncp": "^2.0.0",

src/stores/config.js

@@ -17,8 +17,8 @@ exports.setUp = (basePath, blobStore, locks) => {
           let result
           try {
             result = JSON.parse(config.toString())
-          } catch (error) {
-            return callback(error)
+          } catch (err) {
+            return callback(err)
           }
           callback(null, result)
         }))

test/node.js

@@ -29,17 +29,6 @@ describe('IPFS Repo Tests on on Node.js', () => {
   })
 
   const fs = require('fs-blob-store')
-  const options = {
-    stores: {
-      keys: fs,
-      config: fs,
-      datastore: fs,
-      // datastoreLegacy: needs https://github.com/ipfs/js-ipfs-repo/issues/6#issuecomment-164650642
-      logs: fs,
-      locks: fs,
-      version: fs
-    }
-  }
-  const repo = new IPFSRepo(repoPath, options)
+  const repo = new IPFSRepo(repoPath, {stores: fs})
   require('./repo-test')(repo)
 })

test/repo-test.js

@@ -6,16 +6,11 @@ const expect = require('chai').expect
 const base58 = require('bs58')
 const bl = require('bl')
 const fs = require('fs')
+const join = require('path').join
 
-const isNode = !global.window
+const fileA = fs.readFileSync(join(__dirname, 'test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.data'))
 
-const fileA = isNode
-  ? fs.readFileSync(process.cwd() + '/test/test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.data')
-  : require('buffer!./test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.data')
-
-const fileAExt = isNode
-  ? fs.readFileSync(process.cwd() + '/test/test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.ext')
-  : require('buffer!./test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.ext')
+const fileAExt = fs.readFileSync(join(__dirname, 'test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.ext'))
 
 module.exports = function (repo) {
   describe('IPFS Repo Tests', function () {