-
Notifications
You must be signed in to change notification settings - Fork 47
Pass maxProviders to content routing #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: add package files and remove npmignore
426a512
to
c41f4d8
Compare
package.json
Outdated
@@ -86,8 +90,7 @@ | |||
"varint-decoder": "~0.1.1" | |||
}, | |||
"pre-push": [ | |||
"lint", | |||
"test" | |||
"lint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please keep the pre-push testing. I think they run fast enough so that it is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added that back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for also taking care of updating the deps and fixing the linting errors.
With libp2p 0.24 you can now pass options objects to findProviders. The latest dht updates also include support for maxProviders.
This updates the call to
findProviders
so that both the maxProviders and maxTimeout options are sent.Libp2p 0.24 will be in the js-ipfs 0.34 release, so we should be able to get this update in there as well.
Also in this PR:
files
attributeThe bit change to the key reduced the
test:node
time locally quite a bit:Before
After