This repository was archived by the owner on Mar 23, 2023. It is now read-only.
windows support and add s3 lock to the example #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <[email protected]>
ghost
assigned 
daviddias
previously approved these changes
Apr 24, 2018
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
jacobheun
changed the title
|
@diasdavid no rush on this review, now that ci is all setup on this I fixed the errors there around linting and windows support. It was previously approved but my fixes for CI dismissed the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in the custom s3 lock created in ipfs/js-ipfs#1303, so that the example now uses proper locking.
connects to ipfs/js-ipfs#1303