Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.

chore: upgrade level* components #15

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 1, 2019

leveldown@5 is out and will deal with failures in next month's Node 12 (and warnings with Node 11)

@vweevers
Copy link

vweevers commented Apr 1, 2019

Be advised, this changes the minimum node version to 8.6.0. I had a quick look at src/index.js, it's not affected by other breaking changes AFAICT.

Side note: I think the query() method which currently does a "full scan" can be optimized by using db.iterator({ gte: .. }) instead of:

if (q.prefix != null) {
const prefix = q.prefix
filters.push((e, cb) => cb(null, e.key.toString().startsWith(prefix)))
}

@alanshaw alanshaw requested a review from pgte April 1, 2019 17:51
@rvagg
Copy link
Member Author

rvagg commented Apr 2, 2019

minimum node version to 8.6.0

FYI 6 is EOL next month and 8.6.0 was 18 months ago, so in compatibility terms we're on pretty good ground with this upgrade I think.

@alanshaw
Copy link
Member

alanshaw commented Apr 27, 2019

@pgte can we please get this merged and released now that Node.js 12 is out? 🙏

@pgte pgte merged commit 150ca17 into ipfs:master Apr 29, 2019
@pgte
Copy link
Contributor

pgte commented Apr 29, 2019

Landed on v0.11.0

alanshaw pushed a commit to ipfs/js-ipfs-repo that referenced this pull request May 9, 2019
So we can get the benefits of ipfs/js-datastore-level#15

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants