This repository was archived by the owner on Mar 29, 2023. It is now read-only.
multifilereader: fix multipart/form-data #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://tools.ietf.org/html/rfc7578#section-4.2, in a Content-Disposition header of a part in a multipart/form-data body: - the disposition must be of type `form-data` - a `name` parameter (not explicitely specified by the RFC, but I suppose non-empty) As this `name` parameter is unused by IPFS, this commit simply generate a placeholder with a counter, to conform to the HTTP specification.
|
Those deviations from the RFS break the parsing of multipart/form-data requests (say, |
|
CI failure is unrelated to this PR. |
magik6k
reviewed
Mar 4, 2019
| mpWriter *multipart.Writer | ||
| closed bool | ||
| mutex *sync.Mutex | ||
| fieldCounter int |
| @@ -88,7 +89,10 @@ func (mfr *MultiFileReader) Read(buf []byte) (written int, err error) { | |||
| // write the boundary and headers | |||
| header := make(textproto.MIMEHeader) | |||
| filename := url.QueryEscape(path.Join(path.Join(mfr.path...), entry.Name())) | |||
| header.Set("Content-Disposition", fmt.Sprintf("file; filename=\"%s\"", filename)) | |||
| name := fmt.Sprintf("data%d", mfr.fieldCounter) | |||
There was a problem hiding this comment.
What do browser set this to when user picks multiple files in file input? Can one name repeat?
There was a problem hiding this comment.
https://tools.ietf.org/html/rfc7578#section-4.3
To match widely deployed implementations, multiple files MUST be sent by supplying each file in a separate part but all with the same "name" parameter.
I suppose we want to mimic a form with multiple upload from the same field, so I should change that.
|
Fixed in #14. Thanks for finding this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://tools.ietf.org/html/rfc7578#section-4.2, in a Content-Disposition header
of a part in a multipart/form-data body:
form-datanameparameter (not explicitely specified by the RFC, but I suppose non-empty)As this
nameparameter is unused by IPFS, this commit simply generate a placeholder witha counter, to conform to the HTTP specification.