This repository was archived by the owner on Feb 21, 2018. It is now read-only.
fix: Use Buffer.isBuffer to check buffer type #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
approved these changes
Jan 23, 2017
|
@dignifiedquire wondering what is stopping this PR from getting merged (maybe you just didn't have time to go through it :)) |
|
@diasdavid I was hoping we wouldn't need it, as currently the index.js is a near 1-1 copy from Node.js, and every change makes it harder to maintain. But due to multiple versions possible of |
|
Yeah, the Node.js version doesn't have to deal with Buffer shims nor browsers |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change Buffer type check from
x instanceof BuffertoBuffer.isBuffer(x)