Skip to content
This repository was archived by the owner on Apr 29, 2020. It is now read-only.

WIP - level up libp2p interface and error handling #53

Merged
merged 1 commit into from
May 29, 2016
Merged

Conversation

daviddias
Copy link
Collaborator

@daviddias daviddias commented May 28, 2016

@daviddias daviddias changed the title level up libp2p interface and error handling WIP - level up libp2p interface and error handling May 28, 2016
@coveralls
Copy link

coveralls commented May 28, 2016

Coverage Status

Coverage decreased (-31.1%) to 39.45% when pulling d57b48dd006b1730934c02abb88be3fa4e9016a4 on level-up into 6e2c06a on master.

@dignifiedquire
Copy link
Contributor

This has massive amounts of duplicated code with js-libp2p-ipfs can we please figure out a way to share this code between these two modules?

@daviddias
Copy link
Collaborator Author

@dignifiedquire agree, I've been thinking about it, just afraid of the implications which is coming up with with the interface that does the bindings not adding even more dup/dumb code then what we have already.

(It is also hard to clean the interface until we have the Peer Routing and Content Routing completely ready)

@daviddias daviddias force-pushed the level-up branch 6 times, most recently from 00ecb34 to 7e10adf Compare May 29, 2016 10:17
@coveralls
Copy link

coveralls commented May 29, 2016

Coverage Status

Coverage increased (+4.0%) to 74.561% when pulling 7f0a0db on level-up into 6e2c06a on master.

@daviddias daviddias merged commit 0175dc4 into master May 29, 2016
@daviddias daviddias deleted the level-up branch May 29, 2016 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants