Skip to content
This repository was archived by the owner on Apr 29, 2020. It is now read-only.

test: adds benchmark test #11

Merged
merged 1 commit into from
Dec 21, 2018
Merged

test: adds benchmark test #11

merged 1 commit into from
Dec 21, 2018

Conversation

achingbrain
Copy link
Collaborator

@achingbrain achingbrain commented Dec 21, 2018

Because it's useful to have this somewhere. Skipped because we can use this to do adhoc testing and don't want it to run as part of CI.

It uses 'realistic' data sizes, so 64k incoming chunks and a 500MB file size.

It passes zeroed buffers as using crypto to generate random bytes was a bottleneck and didn't seem to add much to the test.

It runs the test 10 times then prints out the timing data collected while importing the file which you can then use to create graphs in Google Docs or whatever.

@vmx
Copy link
Contributor

vmx commented Dec 21, 2018

Some projects also have a benchmarks folder and using the benchmark module (e.g. https://github.com/multiformats/js-multihashing-async https://github.com/dignifiedquire/borc).

@achingbrain
Copy link
Collaborator Author

...another thing that should be added to aegir

Because it's useful to have this somewhere. Skipped because we can use this to do adhoc testing and don't want it to run as part of CI.

It uses 'realistic' data sizes, so 64k incoming chunks and a 500MB file size.

It passes zeroed buffers as using crypto to generate random bytes was a bottleneck and didn't seem to add much to the test.

It runs the test 10 times then prints out the timing data collected while importing the file which you can then use to create graphs in Google Docs or whatever.
@achingbrain achingbrain merged commit aa86710 into master Dec 21, 2018
@achingbrain achingbrain deleted the add-benchmark-test branch December 21, 2018 14:59
@ghost ghost removed the in progress label Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants