This repository was archived by the owner on Mar 10, 2020. It is now read-only.
use object tests from interface-ipfs-core #267
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,264 @@ | ||
| 'use strict' | ||
|
|
||
| const DAGNode = require('ipfs-merkle-dag').DAGNode | ||
| const DAGLink = require('ipfs-merkle-dag').DAGLink | ||
| const promisify = require('promisify-es6') | ||
| const bs58 = require('bs58') | ||
| const bl = require('bl') | ||
|
|
||
| module.exports = (send) => { | ||
| const api = { | ||
| get: promisify((multihash, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/get', multihash, null, null, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
|
|
||
| const node = new DAGNode(result.Data, result.Links.map( | ||
| (l) => { | ||
| return new DAGLink(l.Name, l.Size, new Buffer(bs58.decode(l.Hash))) | ||
| })) | ||
|
|
||
| callback(null, node) | ||
| }) | ||
| }), | ||
| put: promisify((obj, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
|
|
||
| let tmpObj = { | ||
| Data: null, | ||
| Links: [] | ||
| } | ||
|
|
||
| if (Buffer.isBuffer(obj)) { | ||
| if (!options.enc) { | ||
| tmpObj = { Data: obj.toString(), Links: [] } | ||
| } | ||
| } else if (obj.multihash) { | ||
| tmpObj = { | ||
| Data: obj.data.toString(), | ||
| Links: obj.links.map((l) => { return l.toJSON() }) | ||
| } | ||
| } else if (typeof obj === 'object') { | ||
| tmpObj.Data = obj.Data.toString() | ||
| } else { | ||
| return callback(new Error('obj not recognized')) | ||
| } | ||
|
|
||
| let buf | ||
| if (Buffer.isBuffer(obj) && options.enc) { | ||
| buf = obj | ||
| } else { | ||
| buf = new Buffer(JSON.stringify(tmpObj)) | ||
| } | ||
| const enc = options.enc || 'json' | ||
|
|
||
| send('object/put', enc, null, buf, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
|
|
||
| if (Buffer.isBuffer(obj)) { | ||
| if (!options.enc) { | ||
| obj = { Data: obj, Links: [] } | ||
| } else { | ||
| obj = JSON.parse(obj.toString()) | ||
| } | ||
| } | ||
| let node | ||
| if (obj.multihash) { | ||
| node = obj | ||
| } else { | ||
| node = new DAGNode(obj.Data, obj.Links) | ||
| } | ||
|
|
||
| if (node.toJSON().Hash !== result.Hash) { | ||
| return callback(new Error('Stored object was different from constructed object')) | ||
| } | ||
|
|
||
| callback(null, node) | ||
| }) | ||
| }), | ||
| data: promisify((multihash, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/data', multihash, null, null, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
|
|
||
| result.pipe(bl(callback)) | ||
| }) | ||
| }), | ||
| links: promisify((multihash, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/links', multihash, null, null, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
|
|
||
| let links = [] | ||
|
|
||
| if (result.Links) { | ||
| links = result.Links.map((l) => { | ||
| return new DAGLink(l.Name, l.Size, new Buffer(bs58.decode(l.Hash))) | ||
| }) | ||
| } | ||
| callback(null, links) | ||
| }) | ||
| }), | ||
| stat: promisify((multihash, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/stat', multihash, null, null, callback) | ||
| }), | ||
| new: promisify((callback) => { | ||
|
There was a problem hiding this comment. what about layouts? There was a problem hiding this comment. I tried all the other layouts through the CLI and only There was a problem hiding this comment. Hmm, I made it fully work in js-ipfs :/ There was a problem hiding this comment. Would you like to propose that we shim that feature in, although go-ipfs not supporting? All is possible with code 🎤 :D |
||
| send('object/new', null, null, null, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
| const node = new DAGNode() | ||
|
|
||
| if (node.toJSON().Hash !== result.Hash) { | ||
| return callback(new Error('Stored object was different from constructed object')) | ||
| } | ||
|
|
||
| callback(null, node) | ||
| }) | ||
| }), | ||
| patch: { | ||
| addLink: promisify((multihash, dLink, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/patch/add-link', [multihash, dLink.name, bs58.encode(dLink.hash).toString()], null, null, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
| api.get(result.Hash, { enc: 'base58' }, callback) | ||
| }) | ||
| }), | ||
| rmLink: promisify((multihash, dLink, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/patch/rm-link', [multihash, dLink.name], null, null, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
| api.get(result.Hash, { enc: 'base58' }, callback) | ||
| }) | ||
| }), | ||
| setData: promisify((multihash, data, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/patch/set-data', [multihash], null, data, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
| api.get(result.Hash, { enc: 'base58' }, callback) | ||
| }) | ||
| }), | ||
| appendData: promisify((multihash, data, options, callback) => { | ||
| if (typeof options === 'function') { | ||
| callback = options | ||
| options = {} | ||
| } | ||
| if (!options) { | ||
| options = {} | ||
| } | ||
| multihash = cleanMultihash(multihash, options) | ||
|
|
||
| send('object/patch/append-data', [multihash], null, data, (err, result) => { | ||
| if (err) { | ||
| return callback(err) | ||
| } | ||
| api.get(result.Hash, { enc: 'base58' }, callback) | ||
| }) | ||
| }) | ||
| } | ||
| } | ||
| return api | ||
| } | ||
|
|
||
| function cleanMultihash (multihash, options) { | ||
| if (Buffer.isBuffer(multihash)) { | ||
| if (options.enc) { | ||
| switch (options.enc) { | ||
|
There was a problem hiding this comment. why are you using a |
||
| case 'base58': { | ||
| multihash = multihash.toString() | ||
| break | ||
| } | ||
| default: throw new Error('invalid multihash') | ||
| } | ||
| } else { | ||
| multihash = bs58.encode(multihash).toString() | ||
| } | ||
| } else if (typeof multihash === 'string') { | ||
| if (options.enc) { | ||
| // For the future, when we support more than one enc | ||
| // switch (options.enc) { | ||
| // case 'base58': // It is good | ||
| // } | ||
| } else { | ||
| throw new Error('not valid multihash') | ||
| } | ||
| } | ||
| return multihash | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to support the variety of ways
ipfs.object.putcan be called, I had to break the elegant promise injection that was there before. @dignifiedquire wanna share some wisdom on how we can add promises again, in the most elegant way possible?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably best to just wrap the function using sth like this: https://github.com/manuel-di-iorio/promisify-es6