This repository was archived by the owner on Mar 10, 2020. It is now read-only.
test: extend block coverage #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @gavinmcdermott :) It LGTM, but I defer the final verdict to our in house promise expert, @dignifiedquire, which added the promise support to tell if this matches the pattern he designed for js-ipfs-api :) |
| @@ -8,7 +8,11 @@ module.exports = (send) => { | |||
| stat: argCommand(send, 'block/stat'), | |||
| put (file, cb) { | |||
| if (Array.isArray(file)) { | |||
| return cb(null, new Error('block.put() only accepts 1 file')) | |||
| let err = new Error('block.put() only accepts 1 file') | |||
| if (typeof cb !== 'function') { | |||
There was a problem hiding this comment.
please also check for Promise being defined: https://github.com/ipfs/js-ipfs-api/blob/master/src/api/log.js#L8
There was a problem hiding this comment.
Thanks @dignifiedquire, just getting myself up to speed with the libs to contribute more meaningfully in the near term!
There was a problem hiding this comment.
awesome, thank you @gavinmcdermott :D
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block.putnow returns a rejected promise when no callback is provided and an error occurs; more tests.